ECS verbs and update context menu (#4594)

* Functioning ECS verbs

Currently only ID card console works.

* Changed verb types and allow ID card insertions

* Verb GUI sorting and verb networking

* More networking, and shared components

* Clientside verbs work now.

* Verb enums changed to bitmask flags

* Verb Categories redo

* Fix range check

* GasTank Verb

* Remove unnecessary bodypart verb

* Buckle Verb

* buckle & unbuckle verbs

* Updated range checks

* Item cabinet verbs

* Add range user override

* construction verb

* Chemistry machine verbs

* Climb Verb

* Generalise pulled entity verbs

* ViewVariables Verb

* rejuvenate, delete, sentient, control verbs

* Outfit verb

* inrangeunoccluded and tubedirection verbs

* attach-to verbs

* remove unused verbs and move VV

* Rename DebugVerbSystem

* Ghost role and pointing verbs

* Remove global verbs

* Allow verbs to raise events

* Changing categories and simplifying debug verbs

* Add rotate and flip verbs

* fix rejuvenate test

* redo context menu

* new Add Gas debug verb

* Add Set Temperature debug verb

* Uncuff verb

* Disposal unit verbs

* Add pickup verb

* lock/unlock verb

* Remove verb type, add specific verb events

* rename verb messages -> events

* Context menu displays verbs by interaction type

* Updated context menu HandleMove

previously, checked if entities moved 1 tile from click location.

Now checks if entities moved out of view.

Now you can actually right-click interact with yourself while walking!

* Misc Verb menu GUI changes

* Fix non-human/ghost verbs

* Update types and categories

* Allow non-ghost/human to open context menu

* configuration verb

* tagger verb

* Morgue Verbs

* Medical Scanner Verbs

* Fix solution refactor merge issues

* Fix context menu in-view check

* Remove prepare GUI

* Redo verb restrictions

* Fix context menu UI

* Disposal Verbs

* Spill verb

* Light verb

* Hand Held light verb

* power cell verbs

* storage verbs

and adding names to insert/eject

* Pulling verb

* Close context menu on verb execution

* Strip verb

* AmmoBox verb

* fix pull verb

* gun barrel verbs

revolver verb
energy weapon verbs
Bolt action verb

* Magazine gun barrel  verbs

* Add charger verbs

* PDA verbs

* Transfer amount verb

* Add reagent verb

* make alt-click use ECS verbs

* Delete old verb files

* Magboot verb

* finalising tweaks

* context menu visibility changes

* code cleanup

* Update AdminAddReagentUI.cs

* Remove HasFlag

* Consistent verb keys

* Remove Linq, add comment

* Fix in-inventory check

* Update GUI text alignment and padding

* Added close-menu option

* Changed some "interaction" verbs to "activation"

* Remove verb keys, use sorted sets

* fix master merge

* update some verb text

* Undo Changes

Remove some new verbs that can be added later

undid some .ftl bugfixes, can and should be done separately

* fix merge

* Undo file rename

* fix merge

* Misc Cleanup

* remove contraction

* Fix keybinding issue

* fix comment

* merge fix

* fix merge

* fix merge

* fix merge

* fix merge

* fix open-close verbs

* adjust uncuff verb

* fix merge

and undo the renaming of SharedPullableComponent to PullableComponent. I'm tired of all of those merge conflicts

Content.Client/ContextMenu/UI/ContextMenuElement.cs

@@ -101,7 +101,6 @@ namespace Content.Client.ContextMenu.UI
     public sealed class StackContextElement : ContextMenuElement
      {
          public event Action? OnExitedTree;
-         public readonly TimeSpan HoverDelay = TimeSpan.FromSeconds(0.2);
 
          public HashSet<IEntity> ContextEntities { get; }
          public readonly StackContextElement? Pre;
@@ -176,40 +175,44 @@ namespace Content.Client.ContextMenu.UI
          }
      }
 
-    public sealed class ContextMenuPopup : Robust.Client.UserInterface.Controls.Popup
+    public class ContextMenuPopup : Popup
     {
-        private static readonly Color DefaultColor = Color.FromHex("#1116");
-        private static readonly Color MarginColor = Color.FromHex("#222E");
-        private const int MaxItemsBeforeScroll = 10;
-        private const int MarginSizeBetweenElements = 2;
+        public static readonly Color ButtonColor = Color.FromHex("#1119");
+        public static readonly Color BackgroundColor = Color.FromHex("#333E");
+
+        public const int MaxItemsBeforeScroll = 10;
+        public const int MarginSize = 2;
+        public const int ButtonHeight = 32;
 
         public BoxContainer List { get; }
+        public ScrollContainer Scroll { get; }
         public int Depth { get; }
 
         public ContextMenuPopup(int depth = 0)
         {
+            MaxHeight = MaxItemsBeforeScroll * (ButtonHeight + 2*MarginSize);
+
             Depth = depth;
-            AddChild(new ScrollContainer
+            List = new() { Orientation = LayoutOrientation.Vertical };
+            Scroll = new()
             {
                 HScrollEnabled = false,
-                Children = { new PanelContainer
-                {
-                    Children = { (List = new BoxContainer
-                    {
-                        Orientation = LayoutOrientation.Vertical
-                    }) },
-                    PanelOverride = new StyleBoxFlat {  BackgroundColor = MarginColor }
-                }}
+                Children = { List }
+            };
+            AddChild(new PanelContainer
+            {
+                Children = { Scroll },
+                PanelOverride = new StyleBoxFlat { BackgroundColor = BackgroundColor }
             });
         }
 
-        public void AddToMenu(ContextMenuElement element)
+        public void AddToMenu(Control element)
         {
             List.AddChild(new PanelContainer
             {
                 Children = { element },
-                Margin = new Thickness(0,0,0, MarginSizeBetweenElements),
-                PanelOverride = new StyleBoxFlat {BackgroundColor = DefaultColor}
+                Margin = new Thickness(MarginSize, MarginSize, MarginSize, MarginSize),
+                PanelOverride = new StyleBoxFlat { BackgroundColor = ButtonColor }
             });
         }
 
@@ -229,15 +232,18 @@ namespace Content.Client.ContextMenu.UI
                 return Vector2.Zero;
             }
 
-            List.Measure(availableSize);
-            var listSize = List.DesiredSize;
+            Scroll.Measure(availableSize);
+            var size = List.DesiredSize;
 
-            if (List.ChildCount < MaxItemsBeforeScroll)
+            // account for scroll bar width
+            if (size.Y > MaxHeight)
             {
-                return listSize;
+                // Scroll._vScrollBar is private and ScrollContainer gives no size information :/
+                // 10 = Scroll._vScrollBar.DesiredSize
+                size.X += 10;
             }
-            listSize.Y = MaxItemsBeforeScroll * 32 + MaxItemsBeforeScroll * MarginSizeBetweenElements;
-            return listSize;
+
+            return size;
         }
     }
 }