tommy/tbd-station-14
2
1
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Cleanup SpriteComponent warnings in map renderer (#37609)

Browse Source 
* 3 warnings in EntityPainter

* 1 warning in MapPainter
This commit is contained in:
Tayrtahn
2025-05-19 12:52:04 -04:00
committed by GitHub
parent 9ed6ce581e
commit 69354f59c8
2 changed files with 16 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
Content.MapRenderer/Painters/EntityPainter.cs
View File

@@ -22,12 +22,14 @@ public sealed class EntityPainter
private readonly Image _errorImage; private readonly Image _errorImage;
private readonly IEntityManager _sEntityManager; private readonly IEntityManager _sEntityManager;
private readonly SpriteSystem _sprite;
public EntityPainter(ClientIntegrationInstance client, ServerIntegrationInstance server) public EntityPainter(ClientIntegrationInstance client, ServerIntegrationInstance server)
{ {
_resManager = client.ResolveDependency<IResourceManager>(); _resManager = client.ResolveDependency<IResourceManager>();
_sEntityManager = server.ResolveDependency<IEntityManager>(); _sEntityManager = server.ResolveDependency<IEntityManager>();
_sprite = client.ResolveDependency<IEntityManager>().System<SpriteSystem>();
_images = new Dictionary<(string path, string state), Image>(); _images = new Dictionary<(string path, string state), Image>();
_errorImage = Image.Load<Rgba32>(_resManager.ContentFileRead("/Textures/error.rsi/error.png")); _errorImage = Image.Load<Rgba32>(_resManager.ContentFileRead("/Textures/error.rsi/error.png"));
@@ -44,7 +46,7 @@ public sealed class EntityPainter
foreach (var entity in entities) foreach (var entity in entities)
{ {
Run(canvas, entity, xformSystem, customOffset);; Run(canvas, entity, xformSystem, customOffset);
} }
Console.WriteLine($"{nameof(EntityPainter)} painted {entities.Count} entities in {(int)stopwatch.Elapsed.TotalMilliseconds} ms"); Console.WriteLine($"{nameof(EntityPainter)} painted {entities.Count} entities in {(int)stopwatch.Elapsed.TotalMilliseconds} ms");
@@ -92,7 +94,7 @@ public sealed class EntityPainter
image = image.CloneAs<Rgba32>(); image = image.CloneAs<Rgba32>();
static (int, int, int, int) GetRsiFrame(RSI? rsi, Image image, EntityData entity, ISpriteLayer layer, int direction) (int, int, int, int) GetRsiFrame(RSI? rsi, Image image, EntityData entity, ISpriteLayer layer, int direction)
{ {
if (rsi is null) if (rsi is null)
return (0, 0, EyeManager.PixelsPerMeter, EyeManager.PixelsPerMeter); return (0, 0, EyeManager.PixelsPerMeter, EyeManager.PixelsPerMeter);
@@ -100,14 +102,14 @@ public sealed class EntityPainter
var statesX = image.Width / rsi.Size.X; var statesX = image.Width / rsi.Size.X;
var statesY = image.Height / rsi.Size.Y; var statesY = image.Height / rsi.Size.Y;
var stateCount = statesX * statesY; var stateCount = statesX * statesY;
var frames = stateCount / entity.Sprite.GetLayerDirectionCount(layer); var frames = stateCount / _sprite.LayerGetDirectionCount((SpriteComponent.Layer)layer);
var target = direction * frames; var target = direction * frames;
var targetY = target / statesX; var targetY = target / statesX;
var targetX = target % statesX; var targetX = target % statesX;
return (targetX * rsi.Size.X, targetY * rsi.Size.Y, rsi.Size.X, rsi.Size.Y); return (targetX * rsi.Size.X, targetY * rsi.Size.Y, rsi.Size.X, rsi.Size.Y);
} }
var dir = entity.Sprite.GetLayerDirectionCount(layer) switch var dir = _sprite.LayerGetDirectionCount((SpriteComponent.Layer)layer) switch
{ {
0 => 0, 0 => 0,
_ => (int)layer.EffectiveDirection(worldRotation) _ => (int)layer.EffectiveDirection(worldRotation)
@@ -125,7 +127,7 @@ public sealed class EntityPainter
image.Mutate(o => o.Crop(rect)); image.Mutate(o => o.Crop(rect));
var spriteRotation = 0f; var spriteRotation = 0f;
if (!entity.Sprite.NoRotation && !entity.Sprite.SnapCardinals && entity.Sprite.GetLayerDirectionCount(layer) == 1) if (!entity.Sprite.NoRotation && !entity.Sprite.SnapCardinals && _sprite.LayerGetDirectionCount((SpriteComponent.Layer)layer) == 1)
{ {
spriteRotation = (float)worldRotation.Degrees; spriteRotation = (float)worldRotation.Degrees;
} }

2
Content.MapRenderer/Painters/MapPainter.cs
View File

@@ -56,7 +56,7 @@ namespace Content.MapRenderer.Painters
{ {
if (cEntityManager.TryGetComponent(cPlayerManager.LocalEntity, out SpriteComponent? sprite)) if (cEntityManager.TryGetComponent(cPlayerManager.LocalEntity, out SpriteComponent? sprite))
{ {
sprite.Visible = false; cEntityManager.System<SpriteSystem>().SetVisible((cPlayerManager.LocalEntity.Value, sprite), false);
} }
}); });