tommy/tbd-station-14
2
1
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix RoundEndTest obsolete warnings (#39133)

Browse Source 
We love using low-leaving threading APIs incorrectly.
This commit is contained in:
Pieter-Jan Briers
2025-07-22 16:22:50 +02:00
committed by GitHub
parent 378fbb0ba9
commit 65b4b41928
1 changed files with 10 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
Content.IntegrationTests/Tests/RoundEndTest.cs
View File

@@ -1,4 +1,3 @@
using System.Threading;
using Content.Server.GameTicking; using Content.Server.GameTicking;
using Content.Server.RoundEnd; using Content.Server.RoundEnd;
using Content.Shared.CCVar; using Content.Shared.CCVar;
@@ -22,7 +21,7 @@ namespace Content.IntegrationTests.Tests
private void OnRoundEnd(RoundEndSystemChangedEvent ev) private void OnRoundEnd(RoundEndSystemChangedEvent ev)
{ {
Interlocked.Increment(ref RoundCount); RoundCount += 1;
} }
} }
@@ -127,13 +126,17 @@ namespace Content.IntegrationTests.Tests
async Task WaitForEvent() async Task WaitForEvent()
{ {
var timeout = Task.Delay(TimeSpan.FromSeconds(10)); const int maxTicks = 60;
var currentCount = Thread.VolatileRead(ref sys.RoundCount); var currentCount = sys.RoundCount;
while (currentCount == Thread.VolatileRead(ref sys.RoundCount) && !timeout.IsCompleted) for (var i = 0; i < maxTicks; i++)
{ {
await pair.RunTicksSync(5); if (currentCount != sys.RoundCount)
return;
await pair.RunTicksSync(1);
} }
if (timeout.IsCompleted) throw new TimeoutException("Event took too long to trigger");
throw new TimeoutException("Event took too long to trigger");
} }
// Need to clean self up // Need to clean self up