Attempt to reduce audio helper resolves (#8493)

Content.Shared/Audio/AudioHelpers.cs

@@ -8,9 +8,19 @@ namespace Content.Shared.Audio
         /// <summary>
         ///     Returns a random pitch.
         /// </summary>
+        [Obsolete("Use variant that takes in IRobustRandom instead.")]
         public static AudioParams WithVariation(float amplitude)
         {
-            var scale = (float)(IoCManager.Resolve<IRobustRandom>().NextGaussian(1, amplitude));
+            return WithVariation(amplitude, null);
+        }
+
+        /// <summary>
+        ///     Returns a random pitch.
+        /// </summary>
+        public static AudioParams WithVariation(float amplitude, IRobustRandom? rand)
+        {
+            IoCManager.Resolve(ref rand);
+            var scale = (float) rand.NextGaussian(1, amplitude);
             return AudioParams.Default.WithPitchScale(scale);
         }
 
@@ -43,16 +53,18 @@ namespace Content.Shared.Audio
         /// Returns a pitch multiplier shifted by a random number of semitones within variation.
         /// </summary>
         /// <param name="variation">Max number of semitones to shift in either direction. Values above 12 have no effect.</param>
-        public static AudioParams WithSemitoneVariation(int variation)
+        public static AudioParams WithSemitoneVariation(int variation, IRobustRandom? rand)
         {
+            IoCManager.Resolve(ref rand);
             variation = Math.Clamp(variation, 0, 12);
-            return ShiftSemitone(IoCManager.Resolve<IRobustRandom>().Next(-variation, variation));
+            return ShiftSemitone(rand.Next(-variation, variation));
         }
 
-        public static string GetRandomFileFromSoundCollection(string name)
+        public static string GetRandomFileFromSoundCollection(string name, IRobustRandom? rand, IPrototypeManager? proto)
         {
-            var soundCollection = IoCManager.Resolve<IPrototypeManager>().Index<SoundCollectionPrototype>(name);
-            return IoCManager.Resolve<IRobustRandom>().Pick(soundCollection.PickFiles).ToString();
+            IoCManager.Resolve(ref rand, ref proto);
+            var soundCollection = proto.Index<SoundCollectionPrototype>(name);
+            return rand.Pick(soundCollection.PickFiles).ToString();
         }
     }
 }