tommy/tbd-station-14
2
1
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Truncate long name / job titles for IDs (#5009)

Browse Source
This commit is contained in:
metalgearsloth
2021-10-24 19:28:25 +11:00
committed by GitHub
parent 3c0473dfe4
commit 5cc3f9ee30
3 changed files with 18 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
Content.Client/Access/UI/IdCardConsoleBoundUserInterface.cs
View File

@@ -1,4 +1,5 @@
using System.Collections.Generic;
using Content.Shared.Access;
using Robust.Client.GameObjects;
using Robust.Shared.GameObjects;
using Robust.Shared.IoC;
@@ -40,6 +41,12 @@ namespace Content.Client.Access.UI
public void SubmitData(string newFullName, string newJobTitle, List<string> newAccessList)
{
if (newFullName.Length > MaxFullNameLength)
newFullName = newFullName[..MaxFullNameLength];
if (newJobTitle.Length > MaxJobTitleLength)
newJobTitle = newJobTitle[..MaxJobTitleLength];
SendMessage(new WriteToTargetIdMessage(
newFullName,
newJobTitle,

8
Content.Server/Access/Systems/IdCardSystem.cs
View File

@@ -1,4 +1,5 @@
using Content.Server.Access.Components;
using Content.Shared.Access;
using Robust.Shared.GameObjects;
using Robust.Shared.Localization;
@@ -23,6 +24,10 @@ namespace Content.Server.Access.Systems
if (!Resolve(uid, ref id))
return false;
// TODO: Whenever we get admin logging these should be logged
if (jobTitle.Length > SharedIdCardConsoleComponent.MaxJobTitleLength)
jobTitle = jobTitle[..SharedIdCardConsoleComponent.MaxJobTitleLength];
id.JobTitle = jobTitle;
UpdateEntityName(uid, id);
return true;
@@ -33,6 +38,9 @@ namespace Content.Server.Access.Systems
if (!Resolve(uid, ref id))
return false;
if (fullName.Length > SharedIdCardConsoleComponent.MaxFullNameLength)
fullName = fullName[..SharedIdCardConsoleComponent.MaxFullNameLength];
id.FullName = fullName;
UpdateEntityName(uid, id);
return true;

3
Content.Shared/Access/SharedIdCardConsoleComponent.cs
View File

@@ -9,6 +9,9 @@ namespace Content.Shared.Access
{
public override string Name => "IdCardConsole";
public const int MaxFullNameLength = 256;
public const int MaxJobTitleLength = 256;
public enum UiButton
{
PrivilegedId,