Serialization v3 content PR (#3491)

* serv3 in shared pt 1 * beginning of deepclone api * progress in implementing ideepclone & serv3 in content * adds target * its cant hurt you it cant hurt you * more changes to content.server * adds dataclasses * almost there * renamed & edited entry * finishes refactoring content to use serv3 * gasmixture runtimes, next: reagentunit * fucin hell that was an annoying one * adds flags * fixes some yaml errors * removes comment * fixes generic components for now * removes todo actually clones values my god paul fixes bug involving resolving custom data classes from other proj renames dataclass fixes spritecomp adds WithFormat.Constants support * adds deepclone to ResistanceSet * adds a bunch of deepclone implementations adds a deepclone analyzer (TODO) adds a deep clone fallback for classes & structs * fixes a bunch of runtimes * adds deepclone to entityuid * adds generator to sln * gets rid of warnings * fixes * argh * componentdata refactors * more deepclone impl * heck me i reworked all of content deepclone * renames custom dataclasstarget * misc * reworks prototypes * deepclone nuke * renamed customdataclass attribute * fixes everything * misc fixed * the killcommit * getting there * changed yamlfieldattribute namespace * adds back iselfserialize * renames everything to data(field/definition) * ouch * Fix most errors on content * Fix more errors in content * Fix some components * work on tests * fixes some customdataclasses * fuggin shit * yes * yeas * Remove data classes * Data field naming fixes * arg * Git resetti RobustToolbox * Merge fixes * General fixes * Fix startup serialization errors * Fix DamageContainerPrototype when supported classes or types are null * Implement construction graph step type serializer * Fix up construction serialization * Fix up construction serialization part 2 * Fix null list in technology database component * Fix body serialization * Fix entity storage serialization * Fix actions serialization * Fix AI serialization * Fix reaction serialization * Fix body serialization * Fix grid atmosphere serialization * Rename IServ3Manager to ISerializationManager * Convert every non generic serializer to the new format, general fixes * Serialization and body system fix * pushinheritance fix * Update all prototypes to have a parent and have consistent id/parent properties * Merge fixes * smh my head * cuddling slaps * Content commit for engine PR * stuff * more fixes * argh * yes even you are fixed * changelog fixes * fixes seeds * argh * Test fixes * Add writing for alert order prototype * Fix alert order writing * FIX * its been alot ok * Fix the rest of the visualizers * Fix server alerts component tests * Fix alert prototype tests not using the read value * Fix alert prototype tests initializing serialization multiple times * THIS IS AN AMERICAN CODEBASE GOD BLESS THE USA * Add ImplicitDataDefinitionForInheritors to IMechanismBehavior Fixes the behaviors not being found * Fix NRE in strap component Good night to the 1 buckle optimization * Fix clothing component slot flags serialization tag * Fix body component in all components test * Merge fixes * ffs * Make construction graph prototype use serialization hooks * human yaml linted * a * Do the thing for construction * stuff * a * monke see yaml linter * LINT HARDER * Remove redundant todo * yes * Add skip hook argument to readers and copiers * we gamin * test/datafield fixes * adds more verbose validation * moves linter to action * Improve construction graph step type serializer error message * Fix ammo box component NRE * gamin * some updates to the linter * yes * removes that test * misc fixes * array fix priority fix misc fixes * adds proper info the validation * adds alwaysrelevant usa * Make yaml linter take half as long to run (~50% less) * Make yaml linter 5 times faster (~80% less execution time) * based vera being based * fixes mapsaving * warning cleanup & moves surpressor * removes old msbuild targets * Revert "Make yaml linter 5 times faster (~80% less execution time)" This reverts commit 3e6091359a26252c3e98828199553de668031c63. * Add -nowarn to yaml linter run configuration * Improve yaml linter message feedback * Make dependencies an argument instead of a property on the serialization manager * yamllinting slaps * Clean up type serializers * Move yaml linter code to its own method * Fix yaml errors * Change yaml linter action name and remove -nowarn * yaml linter please shut * Git resetti robust toolbox Co-authored-by: Paul <ritter.paul1+git@googlemail.com> Co-authored-by: DrSmugleaf <DrSmugleaf@users.noreply.github.com>
2021-03-05 01:08:38 +01:00
parent 05d4d9692c
commit 5c50b1f6ed
545 changed files with 4547 additions and 6650 deletions
--- a/Content.YAMLLinter/Program.cs
+++ b/Content.YAMLLinter/Program.cs
@@ -0,0 +1,107 @@
+using System;
+using System.Collections.Generic;
+using System.Linq;
+using System.Threading.Tasks;
+using Content.IntegrationTests;
+using Robust.Shared.Prototypes;
+using Robust.Shared.Serialization.Markdown.Validation;
+using Robust.Shared.Timing;
+using Robust.Shared.Utility;
+
+namespace Content.YAMLLinter
+{
+    internal class Program : ContentIntegrationTest
+    {
+        private static int Main(string[] args)
+        {
+            return new Program().Run();
+        }
+
+        private int Run()
+        {
+            var stopwatch = new Stopwatch();
+            stopwatch.Start();
+
+            var errors = RunValidation().Result;
+
+            if (errors.Count == 0)
+            {
+                Console.WriteLine($"No errors found in {(int) stopwatch.Elapsed.TotalMilliseconds} ms.");
+                return 0;
+            }
+
+            foreach (var (file, errorHashset) in errors)
+            {
+                foreach (var errorNode in errorHashset)
+                {
+                    Console.WriteLine($"({file} | (L:{errorNode.Node.Start.Line}-{errorNode.Node.End.Line} | C:{errorNode.Node.Start.Column}-{errorNode.Node.End.Column}): {errorNode.ErrorReason}");
+                }
+            }
+
+            Console.WriteLine($"{errors.Count} errors found in {(int) stopwatch.Elapsed.TotalMilliseconds} ms.");
+            return -1;
+        }
+
+        private async Task<Dictionary<string, HashSet<ErrorNode>>> ValidateClient()
+        {
+            var client = StartClient();
+
+            await client.WaitIdleAsync();
+
+            var cPrototypeManager = client.ResolveDependency<IPrototypeManager>();
+            var clientErrors = new Dictionary<string, HashSet<ErrorNode>>();
+
+            await client.WaitAssertion(() =>
+            {
+                clientErrors = cPrototypeManager.ValidateDirectory(new ResourcePath("/Prototypes"));
+            });
+
+            client.Stop();
+
+            return clientErrors;
+        }
+
+        private async Task<Dictionary<string, HashSet<ErrorNode>>> ValidateServer()
+        {
+            var server = StartServer();
+
+            await server.WaitIdleAsync();
+
+            var sPrototypeManager = server.ResolveDependency<IPrototypeManager>();
+            var serverErrors = new Dictionary<string, HashSet<ErrorNode>>();
+
+            await server.WaitAssertion(() =>
+            {
+                serverErrors = sPrototypeManager.ValidateDirectory(new ResourcePath("/Prototypes"));
+            });
+
+            server.Stop();
+
+            return serverErrors;
+        }
+
+        public async Task<Dictionary<string, HashSet<ErrorNode>>> RunValidation()
+        {
+            var allErrors = new Dictionary<string, HashSet<ErrorNode>>();
+
+            var tasks = await Task.WhenAll(ValidateClient(), ValidateServer());
+            var clientErrors = tasks[0];
+            var serverErrors = tasks[1];
+
+            foreach (var (key, val) in serverErrors)
+            {
+                if (clientErrors.TryGetValue(key, out var clientVal))
+                {
+                    var newErrors = val.Intersect(clientVal).ToHashSet();
+                    newErrors.UnionWith(val.Where(n => n.AlwaysRelevant));
+                    newErrors.UnionWith(clientVal.Where(n => n.AlwaysRelevant));
+                    if (newErrors.Count == 0) continue;
+
+                    allErrors[key] = newErrors;
+                }
+            }
+
+            return allErrors;
+        }
+    }
+}