Serialization v3 content PR (#3491)

* serv3 in shared pt 1

* beginning of deepclone api

* progress in implementing ideepclone & serv3 in content

* adds target

* its cant hurt you it cant hurt you

* more changes to content.server

* adds dataclasses

* almost there

* renamed & edited entry

* finishes refactoring content to use serv3

* gasmixture runtimes, next: reagentunit

* fucin hell that was an annoying one

* adds flags

* fixes some yaml errors

* removes comment

* fixes generic components for now

* removes todo
actually clones values my god paul
fixes bug involving resolving custom data classes from other proj
renames dataclass
fixes spritecomp
adds WithFormat.Constants support

* adds deepclone to ResistanceSet

* adds a bunch of deepclone implementations
adds a deepclone analyzer (TODO)
adds a deep clone fallback for classes & structs

* fixes a bunch of runtimes

* adds deepclone to entityuid

* adds generator to sln

* gets rid of warnings

* fixes

* argh

* componentdata refactors

* more deepclone impl

* heck me i reworked all of content deepclone

* renames custom dataclasstarget

* misc

* reworks prototypes

* deepclone nuke

* renamed customdataclass attribute

* fixes everything

* misc fixed

* the killcommit

* getting there

* changed yamlfieldattribute namespace

* adds back iselfserialize

* renames everything to data(field/definition)

* ouch

* Fix most errors on content

* Fix more errors in content

* Fix some components

* work on tests

* fixes some customdataclasses

* fuggin shit

* yes

* yeas

* Remove data classes

* Data field naming fixes

* arg

* Git resetti RobustToolbox

* Merge fixes

* General fixes

* Fix startup serialization errors

* Fix DamageContainerPrototype when supported classes or types are null

* Implement construction graph step type serializer

* Fix up construction serialization

* Fix up construction serialization part 2

* Fix null list in technology database component

* Fix body serialization

* Fix entity storage serialization

* Fix actions serialization

* Fix AI serialization

* Fix reaction serialization

* Fix body serialization

* Fix grid atmosphere serialization

* Rename IServ3Manager to ISerializationManager

* Convert every non generic serializer to the new format, general fixes

* Serialization and body system fix

* pushinheritance fix

* Update all prototypes to have a parent and have consistent id/parent properties

* Merge fixes

* smh my head

* cuddling slaps

* Content commit for engine PR

* stuff

* more fixes

* argh

* yes even you are fixed

* changelog fixes

* fixes seeds

* argh

* Test fixes

* Add writing for alert order prototype

* Fix alert order writing

* FIX

* its been alot ok

* Fix the rest of the visualizers

* Fix server alerts component tests

* Fix alert prototype tests not using the read value

* Fix alert prototype tests initializing serialization multiple times

* THIS IS AN AMERICAN CODEBASE GOD BLESS THE USA

* Add ImplicitDataDefinitionForInheritors to IMechanismBehavior
Fixes the behaviors not being found

* Fix NRE in strap component
Good night to the 1 buckle optimization

* Fix clothing component slot flags serialization tag

* Fix body component in all components test

* Merge fixes

* ffs

* Make construction graph prototype use serialization hooks

* human yaml linted

* a

* Do the thing for construction

* stuff

* a

* monke see yaml linter

* LINT HARDER

* Remove redundant todo

* yes

* Add skip hook argument to readers and copiers

* we gamin

* test/datafield fixes

* adds more verbose validation

* moves linter to action

* Improve construction graph step type serializer error message

* Fix ammo box component NRE

* gamin

* some updates to the linter

* yes

* removes that test

* misc fixes

* array fix
priority fix
misc fixes

* adds proper info the validation

* adds alwaysrelevant usa

* Make yaml linter take half as long to run (~50% less)

* Make yaml linter 5 times faster (~80% less execution time)

* based vera being based

* fixes mapsaving

* warning cleanup & moves surpressor

* removes old msbuild targets

* Revert "Make yaml linter 5 times faster (~80% less execution time)"

This reverts commit 3e6091359a26252c3e98828199553de668031c63.

* Add -nowarn to yaml linter run configuration

* Improve yaml linter message feedback

* Make dependencies an argument instead of a property on the serialization manager

* yamllinting slaps

* Clean up type serializers

* Move yaml linter code to its own method

* Fix yaml errors

* Change yaml linter action name and remove -nowarn

* yaml linter please shut

* Git resetti robust toolbox

Co-authored-by: Paul <ritter.paul1+git@googlemail.com>
Co-authored-by: DrSmugleaf <DrSmugleaf@users.noreply.github.com>

Content.Shared/Roles/JobPrototype.cs

@@ -1,10 +1,9 @@
 #nullable enable
 using System;
 using System.Collections.Generic;
-using Robust.Shared.Localization;
 using Robust.Shared.Prototypes;
-using Robust.Shared.Serialization;
-using YamlDotNet.RepresentationModel;
+using Robust.Shared.Serialization.Manager.Attributes;
+using Robust.Shared.ViewVariables;
 
 namespace Content.Shared.Roles
 {
@@ -14,52 +13,55 @@ namespace Content.Shared.Roles
     [Prototype("job")]
     public class JobPrototype : IPrototype
     {
-        public string ID { get; private set; } = string.Empty;
+        private string _name = string.Empty;
+
+        [ViewVariables]
+        [field: DataField("id", required: true)]
+        public string ID { get; } = default!;
+
+        [ViewVariables]
+        [field: DataField("parent")]
+        public string? Parent { get; }
 
         /// <summary>
         ///     The name of this job as displayed to players.
         /// </summary>
-        public string Name { get; private set; } = string.Empty;
+        [field: DataField("name")]
+        public string Name { get; } = string.Empty;
 
         /// <summary>
         ///     Whether this job is a head.
         ///     The job system will try to pick heads before other jobs on the same priority level.
         /// </summary>
+        [DataField("head")]
         public bool IsHead { get; private set; }
 
         /// <summary>
         ///     The total amount of people that can start with this job round-start.
         /// </summary>
-        public int SpawnPositions { get; private set; }
+        public int SpawnPositions => _spawnPositions ?? TotalPositions;
+
+        [DataField("spawnPositions")]
+        private int? _spawnPositions;
 
         /// <summary>
         ///     The total amount of positions available.
         /// </summary>
+        [DataField("positions")]
         public int TotalPositions { get; private set; }
 
-        public string StartingGear { get; private set; } = string.Empty;
+        [DataField("startingGear")]
+        public string? StartingGear { get; private set; }
 
-        public string Icon { get; private set; } = string.Empty;
+        [field: DataField("icon")] public string Icon { get; } = string.Empty;
 
-        public JobSpecial? Special { get; private set; } = null;
+        [DataField("special")]
+        public JobSpecial? Special { get; private set; }
 
-        public IReadOnlyCollection<string> Departments { get; private set; } = Array.Empty<string>();
-        public IReadOnlyCollection<string> Access { get; private set; } = Array.Empty<string>();
+        [field: DataField("departments")]
+        public IReadOnlyCollection<string> Departments { get; } = Array.Empty<string>();
 
-        public void LoadFrom(YamlMappingNode mapping)
-        {
-            var srz = YamlObjectSerializer.NewReader(mapping);
-            ID = srz.ReadDataField<string>("id");
-            Name = Loc.GetString(srz.ReadDataField<string>("name"));
-            StartingGear = srz.ReadDataField<string>("startingGear");
-            Departments = srz.ReadDataField<List<string>>("departments");
-            TotalPositions = srz.ReadDataField<int>("positions");
-
-            srz.DataField(this, p => p.SpawnPositions, "spawnPositions", TotalPositions);
-            srz.DataField(this, p => p.IsHead, "head", false);
-            srz.DataField(this, p => p.Access, "access", Array.Empty<string>());
-            srz.DataField(this, p => p.Icon, "icon", string.Empty);
-            srz.DataField(this, p => p.Special, "special", null);
-        }
+        [field: DataField("access")]
+        public IReadOnlyCollection<string> Access { get; } = Array.Empty<string>();
     }
 }