Serialization v3 content PR (#3491)

* serv3 in shared pt 1

* beginning of deepclone api

* progress in implementing ideepclone & serv3 in content

* adds target

* its cant hurt you it cant hurt you

* more changes to content.server

* adds dataclasses

* almost there

* renamed & edited entry

* finishes refactoring content to use serv3

* gasmixture runtimes, next: reagentunit

* fucin hell that was an annoying one

* adds flags

* fixes some yaml errors

* removes comment

* fixes generic components for now

* removes todo
actually clones values my god paul
fixes bug involving resolving custom data classes from other proj
renames dataclass
fixes spritecomp
adds WithFormat.Constants support

* adds deepclone to ResistanceSet

* adds a bunch of deepclone implementations
adds a deepclone analyzer (TODO)
adds a deep clone fallback for classes & structs

* fixes a bunch of runtimes

* adds deepclone to entityuid

* adds generator to sln

* gets rid of warnings

* fixes

* argh

* componentdata refactors

* more deepclone impl

* heck me i reworked all of content deepclone

* renames custom dataclasstarget

* misc

* reworks prototypes

* deepclone nuke

* renamed customdataclass attribute

* fixes everything

* misc fixed

* the killcommit

* getting there

* changed yamlfieldattribute namespace

* adds back iselfserialize

* renames everything to data(field/definition)

* ouch

* Fix most errors on content

* Fix more errors in content

* Fix some components

* work on tests

* fixes some customdataclasses

* fuggin shit

* yes

* yeas

* Remove data classes

* Data field naming fixes

* arg

* Git resetti RobustToolbox

* Merge fixes

* General fixes

* Fix startup serialization errors

* Fix DamageContainerPrototype when supported classes or types are null

* Implement construction graph step type serializer

* Fix up construction serialization

* Fix up construction serialization part 2

* Fix null list in technology database component

* Fix body serialization

* Fix entity storage serialization

* Fix actions serialization

* Fix AI serialization

* Fix reaction serialization

* Fix body serialization

* Fix grid atmosphere serialization

* Rename IServ3Manager to ISerializationManager

* Convert every non generic serializer to the new format, general fixes

* Serialization and body system fix

* pushinheritance fix

* Update all prototypes to have a parent and have consistent id/parent properties

* Merge fixes

* smh my head

* cuddling slaps

* Content commit for engine PR

* stuff

* more fixes

* argh

* yes even you are fixed

* changelog fixes

* fixes seeds

* argh

* Test fixes

* Add writing for alert order prototype

* Fix alert order writing

* FIX

* its been alot ok

* Fix the rest of the visualizers

* Fix server alerts component tests

* Fix alert prototype tests not using the read value

* Fix alert prototype tests initializing serialization multiple times

* THIS IS AN AMERICAN CODEBASE GOD BLESS THE USA

* Add ImplicitDataDefinitionForInheritors to IMechanismBehavior
Fixes the behaviors not being found

* Fix NRE in strap component
Good night to the 1 buckle optimization

* Fix clothing component slot flags serialization tag

* Fix body component in all components test

* Merge fixes

* ffs

* Make construction graph prototype use serialization hooks

* human yaml linted

* a

* Do the thing for construction

* stuff

* a

* monke see yaml linter

* LINT HARDER

* Remove redundant todo

* yes

* Add skip hook argument to readers and copiers

* we gamin

* test/datafield fixes

* adds more verbose validation

* moves linter to action

* Improve construction graph step type serializer error message

* Fix ammo box component NRE

* gamin

* some updates to the linter

* yes

* removes that test

* misc fixes

* array fix
priority fix
misc fixes

* adds proper info the validation

* adds alwaysrelevant usa

* Make yaml linter take half as long to run (~50% less)

* Make yaml linter 5 times faster (~80% less execution time)

* based vera being based

* fixes mapsaving

* warning cleanup & moves surpressor

* removes old msbuild targets

* Revert "Make yaml linter 5 times faster (~80% less execution time)"

This reverts commit 3e6091359a26252c3e98828199553de668031c63.

* Add -nowarn to yaml linter run configuration

* Improve yaml linter message feedback

* Make dependencies an argument instead of a property on the serialization manager

* yamllinting slaps

* Clean up type serializers

* Move yaml linter code to its own method

* Fix yaml errors

* Change yaml linter action name and remove -nowarn

* yaml linter please shut

* Git resetti robust toolbox

Co-authored-by: Paul <ritter.paul1+git@googlemail.com>
Co-authored-by: DrSmugleaf <DrSmugleaf@users.noreply.github.com>

Content.Shared/Actions/BaseActionPrototype.cs

@@ -1,55 +1,65 @@
 #nullable enable
 using System;
 using System.Collections.Generic;
-using System.Linq;
 using Robust.Shared.Log;
 using Robust.Shared.Prototypes;
 using Robust.Shared.Serialization;
+using Robust.Shared.Serialization.Manager.Attributes;
 using Robust.Shared.Utility;
 using Robust.Shared.ViewVariables;
-using YamlDotNet.RepresentationModel;
 
 namespace Content.Shared.Actions
 {
     /// <summary>
     /// Base class for action prototypes.
     /// </summary>
-    public abstract class BaseActionPrototype : IPrototype
+    [ImplicitDataDefinitionForInheritors]
+    public abstract class BaseActionPrototype : IPrototype, ISerializationHooks
     {
-        public string ID { get; private set; } = string.Empty;
+        public abstract string ID { get; }
+
+        [ViewVariables]
+        [field: DataField("parent")]
+        public string? Parent { get; }
 
         /// <summary>
         /// Icon representing this action in the UI.
         /// </summary>
         [ViewVariables]
-        public SpriteSpecifier Icon { get; private set; } = SpriteSpecifier.Invalid;
+        [field: DataField("icon")]
+        public SpriteSpecifier Icon { get; } = SpriteSpecifier.Invalid;
 
         /// <summary>
         /// For toggle actions only, icon to show when toggled on. If omitted,
         /// the action will simply be highlighted when turned on.
         /// </summary>
         [ViewVariables]
-        public SpriteSpecifier IconOn { get; private set; } = SpriteSpecifier.Invalid;
+        [field: DataField("iconOn")]
+        public SpriteSpecifier IconOn { get; } = SpriteSpecifier.Invalid;
 
         /// <summary>
         /// Name to show in UI. Accepts formatting.
         /// </summary>
+        [DataField("name")]
         public FormattedMessage Name { get; private set; } = new();
 
         /// <summary>
         /// Description to show in UI. Accepts formatting.
         /// </summary>
-        public FormattedMessage Description { get; private set; } = new();
+        [field: DataField("description")]
+        public FormattedMessage Description { get; } = new();
 
         /// <summary>
         /// Requirements message to show in UI. Accepts formatting, but generally should be avoided
         /// so the requirements message isn't too prominent in the tooltip.
         /// </summary>
-        public string Requires { get; private set; } = string.Empty;
+        [field: DataField("requires")]
+        public string Requires { get; } = string.Empty;
 
         /// <summary>
         /// The type of behavior this action has. This is valid clientside and serverside.
         /// </summary>
+        [DataField("behaviorType")]
         public BehaviorType BehaviorType { get; protected set; } = BehaviorType.None;
 
         /// <summary>
@@ -57,29 +67,36 @@ namespace Content.Shared.Actions
         /// selected after it is used, so it can be continuously re-used. If this is false,
         /// the action will be deselected after one use.
         /// </summary>
-        public bool Repeat { get; private set; }
+        [field: DataField("repeat")]
+        public bool Repeat { get; }
 
         /// <summary>
         /// For TargetEntity/TargetPoint actions, should the action be de-selected if currently selected (choosing a target)
         /// when it goes on cooldown. Defaults to false.
         /// </summary>
-        public bool DeselectOnCooldown { get; private set; }
+        [field: DataField("deselectOnCooldown")]
+        public bool DeselectOnCooldown { get; }
 
         /// <summary>
         /// For TargetEntity actions, should the action be de-selected if the user doesn't click an entity when
         /// selecting a target. Defaults to false.
         /// </summary>
-        public bool DeselectWhenEntityNotClicked { get; private set; }
+        [field: DataField("deselectWhenEntityNotClicked")]
+        public bool DeselectWhenEntityNotClicked { get; }
+
+        [DataField("filters")] private List<string> _filters = new();
 
         /// <summary>
         /// Filters that can be used to filter this item in action menu.
         /// </summary>
-        public IEnumerable<string> Filters { get; private set; } = new List<string>();
+        public IEnumerable<string> Filters => _filters;
+
+        [DataField("keywords")] private List<string> _keywords = new();
 
         /// <summary>
         /// Keywords that can be used to search this item in action menu.
         /// </summary>
-        public IEnumerable<string> Keywords { get; private set; } = new List<string>();
+        public IEnumerable<string> Keywords => _keywords;
 
         /// <summary>
         /// True if this is an action that requires selecting a target
@@ -87,27 +104,11 @@ namespace Content.Shared.Actions
         public bool IsTargetAction =>
             BehaviorType == BehaviorType.TargetEntity || BehaviorType == BehaviorType.TargetPoint;
 
-        public virtual void LoadFrom(YamlMappingNode mapping)
+        public virtual void AfterDeserialization()
         {
-            var serializer = YamlObjectSerializer.NewReader(mapping);
+            Name = new FormattedMessage();
+            Name.AddText(ID);
 
-            serializer.DataReadFunction("name", string.Empty,
-                s =>
-                {
-                    ID = s;
-                    Name = FormattedMessage.FromMarkup(s);
-                });
-            serializer.DataReadFunction("description", string.Empty,
-                s => Description = FormattedMessage.FromMarkup(s));
-
-            serializer.DataField(this, x => x.Requires,"requires", string.Empty);
-            serializer.DataField(this, x => x.Icon,"icon", SpriteSpecifier.Invalid);
-            serializer.DataField(this, x => x.IconOn,"iconOn", SpriteSpecifier.Invalid);
-
-            // client needs to know what type of behavior it is even if the actual implementation is only
-            // on server side. If we wanted to avoid this we'd need to always add a shared or clientside interface
-            // for each action even if there was only server-side logic, which would be cumbersome
-            serializer.DataField(this, x => x.BehaviorType, "behaviorType", BehaviorType.None);
             if (BehaviorType == BehaviorType.None)
             {
                 Logger.ErrorS("action", "Missing behaviorType for action with name {0}", Name);
@@ -119,28 +120,12 @@ namespace Content.Shared.Actions
                                         " type was {1}. iconOn is only supported for Toggle behavior type.", Name);
             }
 
-            serializer.DataField(this, x => x.Repeat, "repeat", false);
             if (Repeat && BehaviorType != BehaviorType.TargetEntity && BehaviorType != BehaviorType.TargetPoint)
             {
                 Logger.ErrorS("action", " action named {0} used repeat: true, but this is only supported for" +
                                         " TargetEntity and TargetPoint behaviorType and its behaviorType is {1}",
                     Name, BehaviorType);
             }
-
-            serializer.DataField(this, x => x.DeselectOnCooldown, "deselectOnCooldown", false);
-            serializer.DataField(this, x => x.DeselectWhenEntityNotClicked, "deselectWhenEntityNotClicked", false);
-
-            serializer.DataReadFunction("filters", new List<string>(),
-                rawTags =>
-                {
-                    Filters = rawTags.Select(rawTag => rawTag.Trim()).ToList();
-                });
-
-            serializer.DataReadFunction("keywords", new List<string>(),
-                rawTags =>
-                {
-                    Keywords = rawTags.Select(rawTag => rawTag.Trim()).ToList();
-                });
         }
 
         protected void ValidateBehaviorType(BehaviorType expected, Type actualInterface)