Serialization v3 content PR (#3491)

* serv3 in shared pt 1

* beginning of deepclone api

* progress in implementing ideepclone & serv3 in content

* adds target

* its cant hurt you it cant hurt you

* more changes to content.server

* adds dataclasses

* almost there

* renamed & edited entry

* finishes refactoring content to use serv3

* gasmixture runtimes, next: reagentunit

* fucin hell that was an annoying one

* adds flags

* fixes some yaml errors

* removes comment

* fixes generic components for now

* removes todo
actually clones values my god paul
fixes bug involving resolving custom data classes from other proj
renames dataclass
fixes spritecomp
adds WithFormat.Constants support

* adds deepclone to ResistanceSet

* adds a bunch of deepclone implementations
adds a deepclone analyzer (TODO)
adds a deep clone fallback for classes & structs

* fixes a bunch of runtimes

* adds deepclone to entityuid

* adds generator to sln

* gets rid of warnings

* fixes

* argh

* componentdata refactors

* more deepclone impl

* heck me i reworked all of content deepclone

* renames custom dataclasstarget

* misc

* reworks prototypes

* deepclone nuke

* renamed customdataclass attribute

* fixes everything

* misc fixed

* the killcommit

* getting there

* changed yamlfieldattribute namespace

* adds back iselfserialize

* renames everything to data(field/definition)

* ouch

* Fix most errors on content

* Fix more errors in content

* Fix some components

* work on tests

* fixes some customdataclasses

* fuggin shit

* yes

* yeas

* Remove data classes

* Data field naming fixes

* arg

* Git resetti RobustToolbox

* Merge fixes

* General fixes

* Fix startup serialization errors

* Fix DamageContainerPrototype when supported classes or types are null

* Implement construction graph step type serializer

* Fix up construction serialization

* Fix up construction serialization part 2

* Fix null list in technology database component

* Fix body serialization

* Fix entity storage serialization

* Fix actions serialization

* Fix AI serialization

* Fix reaction serialization

* Fix body serialization

* Fix grid atmosphere serialization

* Rename IServ3Manager to ISerializationManager

* Convert every non generic serializer to the new format, general fixes

* Serialization and body system fix

* pushinheritance fix

* Update all prototypes to have a parent and have consistent id/parent properties

* Merge fixes

* smh my head

* cuddling slaps

* Content commit for engine PR

* stuff

* more fixes

* argh

* yes even you are fixed

* changelog fixes

* fixes seeds

* argh

* Test fixes

* Add writing for alert order prototype

* Fix alert order writing

* FIX

* its been alot ok

* Fix the rest of the visualizers

* Fix server alerts component tests

* Fix alert prototype tests not using the read value

* Fix alert prototype tests initializing serialization multiple times

* THIS IS AN AMERICAN CODEBASE GOD BLESS THE USA

* Add ImplicitDataDefinitionForInheritors to IMechanismBehavior
Fixes the behaviors not being found

* Fix NRE in strap component
Good night to the 1 buckle optimization

* Fix clothing component slot flags serialization tag

* Fix body component in all components test

* Merge fixes

* ffs

* Make construction graph prototype use serialization hooks

* human yaml linted

* a

* Do the thing for construction

* stuff

* a

* monke see yaml linter

* LINT HARDER

* Remove redundant todo

* yes

* Add skip hook argument to readers and copiers

* we gamin

* test/datafield fixes

* adds more verbose validation

* moves linter to action

* Improve construction graph step type serializer error message

* Fix ammo box component NRE

* gamin

* some updates to the linter

* yes

* removes that test

* misc fixes

* array fix
priority fix
misc fixes

* adds proper info the validation

* adds alwaysrelevant usa

* Make yaml linter take half as long to run (~50% less)

* Make yaml linter 5 times faster (~80% less execution time)

* based vera being based

* fixes mapsaving

* warning cleanup & moves surpressor

* removes old msbuild targets

* Revert "Make yaml linter 5 times faster (~80% less execution time)"

This reverts commit 3e6091359a26252c3e98828199553de668031c63.

* Add -nowarn to yaml linter run configuration

* Improve yaml linter message feedback

* Make dependencies an argument instead of a property on the serialization manager

* yamllinting slaps

* Clean up type serializers

* Move yaml linter code to its own method

* Fix yaml errors

* Change yaml linter action name and remove -nowarn

* yaml linter please shut

* Git resetti robust toolbox

Co-authored-by: Paul <ritter.paul1+git@googlemail.com>
Co-authored-by: DrSmugleaf <DrSmugleaf@users.noreply.github.com>

Content.Server/GameObjects/Components/Power/ApcNetComponents/PowerReceiverUsers/BaseCharger.cs

@@ -13,7 +13,9 @@ using Robust.Server.GameObjects;
 using Robust.Shared.Containers;
 using Robust.Shared.GameObjects;
 using Robust.Shared.Localization;
+using Robust.Shared.Prototypes;
 using Robust.Shared.Serialization;
+using Robust.Shared.Serialization.Manager.Attributes;
 using Robust.Shared.ViewVariables;
 
 namespace Content.Server.GameObjects.Components.Power.ApcNetComponents.PowerReceiverUsers
@@ -32,17 +34,12 @@ namespace Content.Server.GameObjects.Components.Power.ApcNetComponents.PowerRece
         private CellChargerStatus _status;
 
         [ViewVariables]
-        private int _chargeRate;
+        [DataField("chargeRate")]
+        private int _chargeRate = 100;
 
         [ViewVariables]
-        private float _transferEfficiency;
-
-        public override void ExposeData(ObjectSerializer serializer)
-        {
-            base.ExposeData(serializer);
-            serializer.DataField(ref _chargeRate, "chargeRate", 100);
-            serializer.DataField(ref _transferEfficiency, "transferEfficiency", 0.85f);
-        }
+        [DataField("transferEfficiency")]
+        private float _transferEfficiency = 0.85f;
 
         public override void Initialize()
         {

Content.Server/GameObjects/Components/Power/ApcNetComponents/PowerReceiverUsers/EmergencyLightComponent.cs

@@ -5,7 +5,9 @@ using Content.Shared.GameObjects.EntitySystems;
 using Robust.Server.GameObjects;
 using Robust.Shared.GameObjects;
 using Robust.Shared.Localization;
+using Robust.Shared.Prototypes;
 using Robust.Shared.Serialization;
+using Robust.Shared.Serialization.Manager.Attributes;
 using Robust.Shared.Utility;
 using Robust.Shared.ViewVariables;
 
@@ -36,19 +38,14 @@ namespace Content.Server.GameObjects.Components.Power.ApcNetComponents.PowerRece
         private EmergencyLightState _state = EmergencyLightState.Empty;
 
         [ViewVariables(VVAccess.ReadWrite)]
-        private float _wattage;
+        [DataField("wattage")]
+        private float _wattage = 5;
         [ViewVariables(VVAccess.ReadWrite)]
-        private float _chargingWattage;
+        [DataField("chargingWattage")]
+        private float _chargingWattage = 60;
         [ViewVariables(VVAccess.ReadWrite)]
-        private float _chargingEfficiency;
-
-        public override void ExposeData(ObjectSerializer serializer)
-        {
-            base.ExposeData(serializer);
-            serializer.DataField(ref _wattage, "wattage", 5);
-            serializer.DataField(ref _chargingWattage, "chargingWattage", 60);
-            serializer.DataField(ref _chargingEfficiency, "chargingEfficiency", 0.85f);
-        }
+        [DataField("chargingEfficiency")]
+        private float _chargingEfficiency = 0.85f;
 
         /// <summary>
         ///     For attaching UpdateState() to events.

Content.Server/GameObjects/Components/Power/ApcNetComponents/PowerReceiverUsers/LightBulbComponent.cs

@@ -10,6 +10,7 @@ using Robust.Shared.Maths;
 using Robust.Shared.Prototypes;
 using Robust.Shared.Random;
 using Robust.Shared.Serialization;
+using Robust.Shared.Serialization.Manager.Attributes;
 using Robust.Shared.ViewVariables;
 
 namespace Content.Server.GameObjects.Components.Power.ApcNetComponents.PowerReceiverUsers
@@ -42,6 +43,7 @@ namespace Content.Server.GameObjects.Components.Power.ApcNetComponents.PowerRece
         public event EventHandler<EventArgs>? OnLightBulbStateChange;
         public event EventHandler<EventArgs?>? OnLightColorChange;
 
+        [DataField("color")]
         private Color _color = Color.White;
 
         [ViewVariables(VVAccess.ReadWrite)] public Color Color
@@ -57,12 +59,15 @@ namespace Content.Server.GameObjects.Components.Power.ApcNetComponents.PowerRece
 
         public override string Name => "LightBulb";
 
+        [DataField("bulb")]
         public LightBulbType Type = LightBulbType.Tube;
 
-        private int _burningTemperature;
+        [DataField("BurningTemperature")]
+        private int _burningTemperature = 1400;
         public int BurningTemperature => _burningTemperature;
 
-        private int _powerUse;
+        [DataField("PowerUse")]
+        private int _powerUse = 40;
         public int PowerUse => _powerUse;
 
         /// <summary>
@@ -94,14 +99,6 @@ namespace Content.Server.GameObjects.Components.Power.ApcNetComponents.PowerRece
 
         private LightBulbState _state = LightBulbState.Normal;
 
-        public override void ExposeData(ObjectSerializer serializer)
-        {
-            serializer.DataField(ref Type, "bulb", LightBulbType.Tube);
-            serializer.DataField(ref _color, "color", Color.White);
-            serializer.DataFieldCached(ref _burningTemperature, "BurningTemperature", 1400);
-            serializer.DataFieldCached(ref _powerUse, "PowerUse", 40);
-        }
-
         public void UpdateColor()
         {
             if (!Owner.TryGetComponent(out SpriteComponent? sprite))

Content.Server/GameObjects/Components/Power/ApcNetComponents/PowerReceiverUsers/PoweredLightComponent.cs

@@ -19,8 +19,7 @@ using Robust.Shared.Containers;
 using Robust.Shared.GameObjects;
 using Robust.Shared.IoC;
 using Robust.Shared.Localization;
-using Robust.Shared.Log;
-using Robust.Shared.Serialization;
+using Robust.Shared.Serialization.Manager.Attributes;
 using Robust.Shared.Timing;
 using Robust.Shared.ViewVariables;
 
@@ -46,13 +45,23 @@ namespace Content.Server.GameObjects.Components.Power.ApcNetComponents.PowerRece
 
         private TimeSpan _lastThunk;
         private TimeSpan? _lastGhostBlink;
-        private bool _hasLampOnSpawn;
 
-        [ViewVariables] private bool _on;
-        [ViewVariables] private bool _currentLit;
-        [ViewVariables] private bool _isBlinking;
-        [ViewVariables] private bool _ignoreGhostsBoo;
+        [DataField("hasLampOnSpawn")]
+        private bool _hasLampOnSpawn = true;
 
+        [ViewVariables] [DataField("on")]
+        private bool _on = true;
+
+        [ViewVariables]
+        private bool _currentLit;
+
+        [ViewVariables]
+        private bool _isBlinking;
+
+        [ViewVariables] [DataField("ignoreGhostsBoo")]
+        private bool _ignoreGhostsBoo;
+
+        [DataField("bulb")]
         private LightBulbType BulbType = LightBulbType.Tube;
         [ViewVariables] private ContainerSlot _lightBulbContainer = default!;
 
@@ -156,14 +165,6 @@ namespace Content.Server.GameObjects.Components.Power.ApcNetComponents.PowerRece
                 bulb.Owner.Transform.Coordinates = user.Transform.Coordinates;
         }
 
-        public override void ExposeData(ObjectSerializer serializer)
-        {
-            serializer.DataField(ref BulbType, "bulb", LightBulbType.Tube);
-            serializer.DataField(ref _on, "on", true);
-            serializer.DataField(ref _hasLampOnSpawn, "hasLampOnSpawn", true);
-            serializer.DataField(ref _ignoreGhostsBoo, "ignoreGhostsBoo", false);
-        }
-
         /// <summary>
         ///     For attaching UpdateLight() to events.
         /// </summary>