Cleanup ChameleonJobLoadoutTest (#38229)

Cleanup ChameleonJobLoadoutTest
This commit is contained in:
Tayrtahn
2025-06-10 18:51:23 -04:00
committed by GitHub
parent 1e0d60826e
commit 5a6ad30ec4

View File

@@ -1,6 +1,4 @@
using System.Collections.Generic; using System.Collections.Generic;
using System.Text;
using Content.Client.Implants;
using Content.IntegrationTests.Tests.Interaction; using Content.IntegrationTests.Tests.Interaction;
using Content.Shared.Clothing; using Content.Shared.Clothing;
using Content.Shared.Implants; using Content.Shared.Implants;
@@ -11,17 +9,17 @@ using Robust.Shared.Prototypes;
namespace Content.IntegrationTests.Tests.Chameleon; namespace Content.IntegrationTests.Tests.Chameleon;
/// <summary> /// <summary>
/// Ensures all round <see cref="IsProbablyRoundStartJob">"round start jobs"</see> have an associated chameleon loadout. /// Ensures all <see cref="IsProbablyRoundStartJob">"round start jobs"</see> have an associated chameleon loadout.
/// </summary> /// </summary>
public sealed class ChameleonJobLoadoutTest : InteractionTest public sealed class ChameleonJobLoadoutTest : InteractionTest
{ {
private readonly List<ProtoId<JobPrototype>> JobBlacklist = private static readonly List<ProtoId<JobPrototype>> JobBlacklist =
[ [
]; ];
[Test] [Test]
public async Task CheckAllJobs() public Task CheckAllJobs()
{ {
var alljobs = ProtoMan.EnumeratePrototypes<JobPrototype>(); var alljobs = ProtoMan.EnumeratePrototypes<JobPrototype>();
@@ -47,24 +45,16 @@ public sealed class ChameleonJobLoadoutTest : InteractionTest
validJobs[chameleon.Job.Value] += 1; validJobs[chameleon.Job.Value] += 1;
} }
var errorMessage = new StringBuilder(); Assert.Multiple(() =>
errorMessage.AppendLine("The following job(s) have no chameleon prototype(s):");
var invalid = false;
// All round start jobs have a chameleon loadout
foreach (var job in validJobs)
{ {
if (job.Value != 0) foreach (var job in validJobs)
continue; {
Assert.That(job.Value, Is.Not.Zero,
$"{job.Key} has no chameleonOutfit prototype.");
}
});
errorMessage.AppendLine(job.Key + " has no chameleonOutfit prototype."); return Task.CompletedTask;
invalid = true;
}
if (!invalid)
return;
Assert.Fail(errorMessage.ToString());
} }
/// <summary> /// <summary>