From 5a586604d2f35c24d45582f5ecefdff5a0eaba42 Mon Sep 17 00:00:00 2001
From: deltanedas <39013340+deltanedas@users.noreply.github.com>
Date: Sat, 16 Sep 2023 13:59:27 +0100
Subject: [PATCH] better logging for shared objective system (#20253)

Co-authored-by: deltanedas <@deltanedas:kde.org>
---
 .../Objectives/Systems/SharedObjectivesSystem.cs          | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/Content.Shared/Objectives/Systems/SharedObjectivesSystem.cs b/Content.Shared/Objectives/Systems/SharedObjectivesSystem.cs
index dffb4e75c0..2e1bdc4383 100644
--- a/Content.Shared/Objectives/Systems/SharedObjectivesSystem.cs
+++ b/Content.Shared/Objectives/Systems/SharedObjectivesSystem.cs
@@ -63,12 +63,9 @@ public abstract class SharedObjectivesSystem : EntitySystem
             return null;
         }
 
-        Log.Debug($"Created objective {proto} ({uid})");
-
         if (!CanBeAssigned(uid, mindId, mind, comp))
         {
-            Del(uid);
-            Log.Warning($"Objective {uid} did not match the requirements for {_mind.MindOwnerLoggingString(mind)}, deleted it");
+            Log.Warning($"Objective {proto} did not match the requirements for {_mind.MindOwnerLoggingString(mind)}, deleted it");
             return null;
         }
 
@@ -77,7 +74,7 @@ public abstract class SharedObjectivesSystem : EntitySystem
         if (ev.Cancelled)
         {
             Del(uid);
-            Log.Warning($"Could not assign objective {uid}, deleted it");
+            Log.Warning($"Could not assign objective {proto}, deleted it");
             return null;
         }
 
@@ -85,6 +82,7 @@ public abstract class SharedObjectivesSystem : EntitySystem
         var afterEv = new ObjectiveAfterAssignEvent(mindId, mind, comp, MetaData(uid));
         RaiseLocalEvent(uid, ref afterEv);
 
+        Log.Debug($"Created objective {ToPrettyString(uid):objective}");
         return uid;
     }