Pump enabled animation (#1973)

* Pump enabled animation

* naming fixes

Co-authored-by: py01 <pyronetics01@gmail.com>

Content.Client/GameObjects/Components/Atmos/PumpVisualizer.cs

@@ -12,7 +12,7 @@ using Robust.Shared.Utility;
 using System;
 using YamlDotNet.RepresentationModel;
 
-namespace Content.Client.GameObjects.Components.Disposal
+namespace Content.Client.GameObjects.Components.Atmos
 {
     [UsedImplicitly]
     public class PumpVisualizer : AppearanceVisualizer
@@ -60,11 +60,26 @@ namespace Content.Client.GameObjects.Components.Disposal
             sprite.LayerSetRSI(basePumpLayer, _pumpRSI);
             sprite.LayerSetState(basePumpLayer, pumpBaseState);
             sprite.LayerSetVisible(basePumpLayer, true);
+
+
+
+            var pumpEnabledAnimationState = "pumpEnabled";
+            pumpEnabledAnimationState += pumpVisualState.InletDirection.ToString();
+            pumpEnabledAnimationState += ((int) pumpVisualState.InletConduitLayer).ToString();
+            pumpEnabledAnimationState += pumpVisualState.OutletDirection.ToString();
+            pumpEnabledAnimationState += ((int) pumpVisualState.OutletConduitLayer).ToString();
+
+            sprite.LayerMapReserveBlank(Layer.PumpEnabled);
+            var pumpEnabledAnimationLayer = sprite.LayerMapGet(Layer.PumpEnabled);
+            sprite.LayerSetRSI(pumpEnabledAnimationLayer, _pumpRSI);
+            sprite.LayerSetState(pumpEnabledAnimationLayer, pumpEnabledAnimationState);
+            sprite.LayerSetVisible(pumpEnabledAnimationLayer, pumpVisualState.PumpEnabled);
         }
 
         private enum Layer
         {
-            PumpBase
+            PumpBase,
+            PumpEnabled,
         }
     }
 }

Content.Server/GameObjects/Components/Atmos/Piping/Pumps/BasePumpComponent.cs

@@ -16,6 +16,21 @@ namespace Content.Server.GameObjects.Components.Atmos.Piping
     /// </summary>
     public abstract class BasePumpComponent : PipeNetDeviceComponent
     {
+        /// <summary>
+        ///     If the pump is currently pumping.
+        /// </summary>
+        [ViewVariables(VVAccess.ReadWrite)]
+        public bool PumpEnabled
+        {
+            get => _pumpEnabled;
+            set
+            {
+                _pumpEnabled = value;
+                UpdateAppearance();
+            }
+        }
+        private bool _pumpEnabled = true;
+
         /// <summary>
         ///     Needs to be same <see cref="PipeDirection"/> as that of a <see cref="Pipe"/> on this entity.
         /// </summary>
@@ -67,6 +82,9 @@ namespace Content.Server.GameObjects.Components.Atmos.Piping
 
         public override void Update()
         {
+            if (!PumpEnabled)
+                return;
+
             PumpGas(_inletPipe.Air, _outletPipe.Air);
         }
 
@@ -74,7 +92,7 @@ namespace Content.Server.GameObjects.Components.Atmos.Piping
 
         private void UpdateAppearance()
         {
-            _appearance?.SetData(PumpVisuals.VisualState, new PumpVisualState(_inletDirection, _outletDirection, _inletPipe.ConduitLayer, _outletPipe.ConduitLayer));
+            _appearance?.SetData(PumpVisuals.VisualState, new PumpVisualState(_inletDirection, _outletDirection, _inletPipe.ConduitLayer, _outletPipe.ConduitLayer, PumpEnabled));
         }
     }
 }

Content.Shared/GameObjects/Atmos/SharedPumpComponent.cs

@@ -17,13 +17,15 @@ namespace Content.Shared.GameObjects.Atmos
         public readonly PipeDirection OutletDirection;
         public readonly ConduitLayer InletConduitLayer;
         public readonly ConduitLayer OutletConduitLayer;
+        public readonly bool PumpEnabled;
 
-        public PumpVisualState(PipeDirection inletDirection, PipeDirection outletDirection, ConduitLayer inletConduitLayer, ConduitLayer outletConduitLayer)
+        public PumpVisualState(PipeDirection inletDirection, PipeDirection outletDirection, ConduitLayer inletConduitLayer, ConduitLayer outletConduitLayer, bool pumpEnabled)
         {
             InletDirection = inletDirection;
             OutletDirection = outletDirection;
             InletConduitLayer = inletConduitLayer;
             OutletConduitLayer = outletConduitLayer;
+            PumpEnabled = pumpEnabled;
         }
     }
 }

Resources/Textures/Constructible/Atmos/pressurepump.rsi/meta.json

@@ -26,6 +26,26 @@
          "name":"pumpWest2East2",
          "directions":1,
          "delays":[ [ 1.0 ] ]
+      },
+      {
+         "name":"pumpEnabledEast2West2",
+         "directions":1,
+         "delays":[ [ 0.1, 0.1, 0.1, 0.1, 0.1 ] ]
+      },
+      {
+         "name":"pumpEnabledNorth2South2",
+         "directions":1,
+         "delays":[ [ 0.1, 0.1, 0.1, 0.1, 0.1 ] ]
+      },
+      {
+         "name":"pumpEnabledSouth2North2",
+         "directions":1,
+         "delays":[ [ 0.1, 0.1, 0.1, 0.1, 0.1 ] ]
+      },
+      {
+         "name":"pumpEnabledWest2East2",
+         "directions":1,
+         "delays":[ [ 0.1, 0.1, 0.1, 0.1, 0.1 ] ]
       }
    ]
 }