Physics (#3485)

* Content side new physics structure

* BroadPhase outline done

* But we need to fix WorldAABB

* Fix static pvs AABB

* Fix import

* Rando fixes

* B is for balloon

* Change human mob hitbox to circle

* Decent movement

* Start adding friction to player controller

I think it's the best way to go about it to keep other objects somewhat consistent for physics.

* This baby can fit so many physics bugs in it.

* Slight mob mover optimisations.

* Player mover kinda works okay.

* Beginnings of testbed

* More testbed

* Circlestack bed

* Namespaces

* BB fixes

* Pull WorldAABB

* Joint pulling

* Semi-decent movement I guess.

* Pulling better

* Bullet controller + old movement

* im too dumb for this shit

* Use kinematic mob controller again

It's probably for the best TBH

* Stashed shitcode

* Remove SlipController

* In which movement code is entirely refactored

* Singularity fix

* Fix ApplyLinearImpulse

* MoveRelay fix

* Fix door collisions

* Disable subfloor collisions

Saves on broadphase a fair bit

* Re-implement ClimbController

* Zumzum's pressure

* Laggy item throwing

* Minor atmos change

* Some caching

* Optimise controllers

* Optimise CollideWith to hell and back

* Re-do throwing and tile friction

* Landing too

* Optimise controllers

* Move CCVars and other stuff swept is beautiful

* Cleanup a bunch of controllers

* Fix shooting and high pressure movement controller

* Flashing improvements

* Stuff and things

* Combat collisions

* Combat mode collisions

* Pulling distance joint again

* Cleanup physics interfaces

* More like scuffedularity

* Shit's fucked

* Haha tests go green

* Bigmoneycrab

* Fix dupe pulling

* Zumzum's based fix

* Don't run tile friction for non-predicted bodies

* Experimental pulling improvement

* Everything's a poly now

* Optimise AI region debugging a bit

Could still be better but should improve default performance a LOT

* Mover no updater

* Crazy kinematic body idea

* Good collisions

* KinematicController

* Fix aghost

* Throwing refactor

* Pushing cleanup

* Fix throwing and footstep sounds

* Frametime in ICollideBehavior

* Fix stuff

* Actually fix weightlessness

* Optimise collision behaviors a lot

* Make open lockers still collide with walls

* powwweeerrrrr

* Merge master proper

* AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA

* AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA

* AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA

* Ch ch ch changesss

* SHIP IT

* Fix #if DEBUG

* Fix vaulting and item locker collision

* Fix throwing

* Editing yaml by hand what can go wrong

* on

* Last yaml fixes

* Okay now it's fixed

* Linter

Co-authored-by: Metal Gear Sloth <metalgearsloth@gmail.com>
Co-authored-by: Vera Aguilera Puerto <zddm@outlook.es>

Content.Shared/GameObjects/Components/Movement/SharedPlayerInputMoverComponent.cs

@@ -5,7 +5,6 @@ using Robust.Shared.Configuration;
 using Robust.Shared.GameObjects;
 using Robust.Shared.IoC;
 using Robust.Shared.Log;
-using Robust.Shared.Map;
 using Robust.Shared.Maths;
 using Robust.Shared.Physics;
 using Robust.Shared.Players;
@@ -15,7 +14,9 @@ using Robust.Shared.ViewVariables;
 
 namespace Content.Shared.GameObjects.Components.Movement
 {
-    public abstract class SharedPlayerInputMoverComponent : Component, IMoverComponent, ICollideSpecial
+    [RegisterComponent]
+    [ComponentReference(typeof(IMoverComponent))]
+    public class SharedPlayerInputMoverComponent : Component, IMoverComponent
     {
         // This class has to be able to handle server TPS being lower than client FPS.
         // While still having perfectly responsive movement client side.
@@ -39,8 +40,10 @@ namespace Content.Shared.GameObjects.Components.Movement
         [Dependency] private readonly IConfigurationManager _configurationManager = default!;
         [Dependency] private readonly IGameTiming _gameTiming = default!;
 
-        public sealed override string Name => "PlayerInputMover";
-        public sealed override uint? NetID => ContentNetIDs.PLAYER_INPUT_MOVER;
+        [ComponentDependency] private readonly MovementSpeedModifierComponent? _movementSpeed = default!;
+
+        public override string Name => "PlayerInputMover";
+        public override uint? NetID => ContentNetIDs.PLAYER_INPUT_MOVER;
 
         private GameTick _lastInputTick;
         private ushort _lastInputSubTick;
@@ -49,36 +52,10 @@ namespace Content.Shared.GameObjects.Components.Movement
 
         private MoveButtons _heldMoveButtons = MoveButtons.None;
 
-        public float CurrentWalkSpeed
-        {
-            get
-            {
-                if (Owner.TryGetComponent(out MovementSpeedModifierComponent? component))
-                {
-                    return component.CurrentWalkSpeed;
-                }
+        public float CurrentWalkSpeed => _movementSpeed?.CurrentWalkSpeed ?? MovementSpeedModifierComponent.DefaultBaseWalkSpeed;
 
-                return MovementSpeedModifierComponent.DefaultBaseWalkSpeed;
-            }
-        }
+        public float CurrentSprintSpeed => _movementSpeed?.CurrentSprintSpeed ?? MovementSpeedModifierComponent.DefaultBaseSprintSpeed;
 
-        public float CurrentSprintSpeed
-        {
-            get
-            {
-                if (Owner.TryGetComponent(out MovementSpeedModifierComponent? component))
-                {
-                    return component.CurrentSprintSpeed;
-                }
-
-                return MovementSpeedModifierComponent.DefaultBaseSprintSpeed;
-            }
-        }
-
-        [ViewVariables(VVAccess.ReadWrite)]
-        public float CurrentPushSpeed => 5;
-        [ViewVariables(VVAccess.ReadWrite)]
-        public float GrabRange => 0.2f;
         public bool Sprinting => !HasFlag(_heldMoveButtons, MoveButtons.Walk);
 
         /// <summary>
@@ -131,9 +108,6 @@ namespace Content.Shared.GameObjects.Components.Movement
             }
         }
 
-        public abstract EntityCoordinates LastPosition { get; set; }
-        public abstract float StepSoundDistance { get; set; }
-
         /// <summary>
         ///     Whether or not the player can move diagonally.
         /// </summary>
@@ -141,18 +115,12 @@ namespace Content.Shared.GameObjects.Components.Movement
         public bool DiagonalMovementEnabled => _configurationManager.GetCVar<bool>(CCVars.GameDiagonalMovement);
 
         /// <inheritdoc />
-        public override void OnAdd()
+        public override void Initialize()
         {
-            // This component requires that the entity has a IPhysicsComponent.
-            if (!Owner.HasComponent<IPhysicsComponent>())
-                Logger.Error(
-                    $"[ECS] {Owner.Prototype?.Name} - {nameof(SharedPlayerInputMoverComponent)} requires" +
-                    $" {nameof(IPhysicsComponent)}. ");
-
-            base.OnAdd();
+            base.Initialize();
+            Owner.EnsureComponentWarn<PhysicsComponent>();
         }
 
-
         /// <summary>
         ///     Toggles one of the four cardinal directions. Each of the four directions are
         ///     composed into a single direction vector, <see cref="VelocityDir"/>. Enabling
@@ -266,12 +234,6 @@ namespace Content.Shared.GameObjects.Components.Movement
             return vec;
         }
 
-        bool ICollideSpecial.PreventCollide(IPhysBody collidedWith)
-        {
-            // Don't collide with other mobs
-            return collidedWith.Entity.HasComponent<IBody>();
-        }
-
         [Serializable, NetSerializable]
         private sealed class MoverComponentState : ComponentState
         {