tommy/tbd-station-14
2
1
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Enum.HasFlag was causing tons of boxing allocations, this adds a custom function that does not allocate.

Browse Source
This commit is contained in:
Acruid
2020-06-29 22:51:47 -07:00
parent 49586e5dcb
commit 49aa1da3a3
1 changed files with 11 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
Content.Shared/GameObjects/Components/Movement/SharedPlayerInputMoverComponent.cs
View File

@@ -1,4 +1,4 @@
using System; using System;
using Content.Shared.GameObjects.Components.Mobs; using Content.Shared.GameObjects.Components.Mobs;
using Robust.Shared.GameObjects; using Robust.Shared.GameObjects;
using Robust.Shared.GameObjects.Components; using Robust.Shared.GameObjects.Components;
@@ -79,7 +79,7 @@ namespace Content.Shared.GameObjects.Components.Movement
public float CurrentPushSpeed => 5; public float CurrentPushSpeed => 5;
public float GrabRange => 0.2f; public float GrabRange => 0.2f;
public bool Sprinting => !_heldMoveButtons.HasFlag(MoveButtons.Walk); public bool Sprinting => !HasFlag(_heldMoveButtons, MoveButtons.Walk);
/// <summary> /// <summary>
/// Calculated linear velocity direction of the entity. /// Calculated linear velocity direction of the entity.
@@ -241,14 +241,14 @@ namespace Content.Shared.GameObjects.Components.Movement
// if the camera is moved, this needs to be changed // if the camera is moved, this needs to be changed
var x = 0; var x = 0;
x -= buttons.HasFlag(MoveButtons.Left) ? 1 : 0; x -= HasFlag(buttons, MoveButtons.Left) ? 1 : 0;
x += buttons.HasFlag(MoveButtons.Right) ? 1 : 0; x += HasFlag(buttons, MoveButtons.Right) ? 1 : 0;
var y = 0; var y = 0;
if (DiagonalMovementEnabled || x == 0) if (DiagonalMovementEnabled || x == 0)
{ {
y -= buttons.HasFlag(MoveButtons.Down) ? 1 : 0; y -= HasFlag(buttons, MoveButtons.Down) ? 1 : 0;
y += buttons.HasFlag(MoveButtons.Up) ? 1 : 0; y += HasFlag(buttons, MoveButtons.Up) ? 1 : 0;
} }
var vec = new Vector2(x, y); var vec = new Vector2(x, y);
@@ -291,5 +291,10 @@ namespace Content.Shared.GameObjects.Components.Movement
Right = 8, Right = 8,
Walk = 16, Walk = 16,
} }
private static bool HasFlag(MoveButtons buttons, MoveButtons flag)
{
return (buttons & flag) == flag;
}
} }
} }