PopupSystem now uses Filter methods for getting players from entities. (#4751)

Content.Client/Popups/PopupSystem.cs

@@ -79,24 +79,24 @@ namespace Content.Client.Popups
         {
             if (!filter.CheckPrediction)
                 return;
+
+            PopupCursor(message);
         }
 
         public override void PopupCoordinates(string message, EntityCoordinates coordinates, Filter filter)
         {
             if (!filter.CheckPrediction)
                 return;
+
+            PopupCoordinates(message, coordinates);
         }
 
         public override void PopupEntity(string message, EntityUid uid, Filter filter)
         {
             if (!filter.CheckPrediction)
                 return;
-        }
 
-        public override Filter GetFilterFromEntity(IEntity entity)
+            PopupEntity(message, uid);
-        {
-            return _playerManager.LocalPlayer?.ControlledEntity == entity
-                ? Filter.Local() : Filter.Empty().Unpredicted();
         }
 
         #endregion

Content.Server/Popups/PopupSystem.cs

@@ -22,11 +22,5 @@ namespace Content.Server.Popups
         {
             RaiseNetworkEvent(new PopupEntityEvent(message, uid), filter);
         }
-
-        public override Filter GetFilterFromEntity(IEntity entity)
-        {
-            return entity.TryGetComponent(out ActorComponent? actor)
-                ? Filter.SinglePlayer(actor.PlayerSession) : Filter.Empty();
-        }
     }
 }

Content.Shared/Popups/SharedPopupSystem.cs

@@ -39,7 +39,10 @@ namespace Content.Shared.Popups
         ///     player attached to the entity.
         /// </summary>
         /// <remarks>Using this method is NOT recommended, please use one of the other methods instead.</remarks>
-        public abstract Filter GetFilterFromEntity(IEntity entity);
+        public Filter GetFilterFromEntity(IEntity entity)
+        {
+            return Filter.Entities(entity.Uid);
+        }
     }
 
     /// <summary>