fix the last ignored prototypes in prototype save test (#13672)

Closes https://github.com/space-wizards/space-station-14/issues/10595

Content.IntegrationTests/Tests/PrototypeSaveTest.cs

@@ -36,41 +36,6 @@ public sealed class PrototypeSaveTest
     {
         "Singularity", // physics collision uses "AllMask" (-1). The flag serializer currently fails to save this because this features un-named bits.
         "constructionghost",
-
-        // TODO fix more prototypes
-        // The rest of these prototypes (probably) shouldn't be getting ignored.
-        // There should be an issue up tracking all of these prototypes, indicating that still need to get fixed.
-        "HeadSkeleton",
-        // The followjng are all fixture-less phsyics entities that set can-collide to false on init.
-        "CarpRift",
-        "GasMinerOxygen",
-        "GasMinerNitrogen",
-        "GasMinerCarbonDioxide",
-        "GasMinerPlasma",
-        "GasMinerTritium",
-        "GasMinerWaterVapor",
-        "GasMinerMiasma",
-        "GasMinerNitrousOxide",
-        "SignalSwitch",
-        "SignalButton",
-        "ApcNetSwitch",
-        "SignalButtonExt1",
-        "SignalButtonExt2",
-        "SignalButtonExt3",
-        "SignalButtonBridge",
-        "SignalButtonWindows",
-        "GrilleBroken",
-        "BaseGeneratorWallmountFrame",
-        "GeneratorWallmountBasic",
-        "GeneratorWallmountAPU",
-        "Lightning",
-        "LightningRevenant",
-        "ChargedLightning",
-        "SuperchargedLightning",
-        "HyperchargedLightning",
-        "BaseSubstationWall",
-        "SubstationWallBasic",
-        "BaseSubstationWallFrame"
     };
 
     [Test]

Content.Server/Speech/VocalSystem.cs

@@ -32,11 +32,11 @@ public sealed class VocalSystem : EntitySystem
         base.Initialize();
 
         SubscribeLocalEvent<VocalComponent, ScreamActionEvent>(OnActionPerform);
-        SubscribeLocalEvent<VocalComponent, ComponentStartup>(OnStartup);
+        SubscribeLocalEvent<VocalComponent, MapInitEvent>(OnMapInit);
         SubscribeLocalEvent<VocalComponent, ComponentShutdown>(OnShutdown);
     }
 
-    private void OnStartup(EntityUid uid, VocalComponent component, ComponentStartup args)
+    private void OnMapInit(EntityUid uid, VocalComponent component, MapInitEvent args)
     {
         if (component.ScreamAction == null
             && _proto.TryIndex(component.ActionId, out InstantActionPrototype? act))

Resources/Prototypes/Entities/Effects/lightning.yml

@@ -11,6 +11,7 @@
     - state: "lightning_1"
       shader: unshaded
   - type: Physics
+    canCollide: false
   - type: Electrified
     requirePower: false
   - type: Lightning

Resources/Prototypes/Entities/Structures/Piping/Atmospherics/miners.yml

@@ -9,6 +9,7 @@
     - type: Clickable
     - type: InteractionOutline
     - type: Physics
+      canCollide: false
     - type: Fixtures
     - type: Transform
       anchored: true

Resources/Prototypes/Entities/Structures/Power/Generation/generators.yml

@@ -96,6 +96,9 @@
   - type: Fixtures
   - type: Transform
     anchored: true
+  - type: Physics
+    bodyType: Static
+    canCollide: false
   - type: Sprite
     drawdepth: WallMountedItems
     netsync: false
@@ -132,6 +135,7 @@
   - type: Clickable
   - type: InteractionOutline
   - type: Physics
+    canCollide: false
   - type: Fixtures
   - type: Transform
     anchored: true

Resources/Prototypes/Entities/Structures/Power/substation.yml

@@ -102,6 +102,7 @@
   - type: InteractionOutline
   - type: Physics
     bodyType: Static
+    canCollide: false
   - type: Fixtures
   - type: Transform
     anchored: true
@@ -202,6 +203,7 @@
   - type: InteractionOutline
   - type: Physics
     bodyType: Static
+    canCollide: false
   - type: Fixtures
   - type: Transform
     anchored: true

Resources/Prototypes/Entities/Structures/Specific/dragon.yml

@@ -10,6 +10,7 @@
       anchored: true
     - type: Physics
       bodyType: Static
+      canCollide: false
     - type: Fixtures
     - type: Sprite
       netsync: false

Resources/Prototypes/Entities/Structures/Wallmounts/switch.yml

@@ -12,6 +12,7 @@
   - type: Clickable
   - type: InteractionOutline
   - type: Physics
+    canCollide: false
   - type: Sprite
     sprite: Structures/Wallmounts/switch.rsi
     state: on
@@ -42,6 +43,7 @@
   - type: Clickable
   - type: InteractionOutline
   - type: Physics
+    canCollide: false
   - type: Sprite
     sprite: Structures/Wallmounts/switch.rsi
     state: dead
@@ -87,6 +89,7 @@
     - type: Clickable
     - type: InteractionOutline
     - type: Physics
+      canCollide: false
     - type: Transform
       anchored: true
     - type: Sprite

Resources/Prototypes/Entities/Structures/Walls/grille.yml

@@ -94,6 +94,9 @@
       node: grilleBroken
       deconstructionTarget: start
     - type: Fixtures # overwrite BaseStructure parent.
+    - type: Physics
+      bodyType: Static
+      canCollide: false
     - type: Damageable
       damageContainer: Inorganic
       damageModifierSet: FlimsyMetallic