Pullability partial ECS refactor, monkey-gibbing error fix (#4695)

* Migrate lots of pulling logic out of the components and clean it up

* It's buggy, but move more code out of the pullable component

* Pulling system now throws less errors than it did before the refactor

* Finally finish the big parts of refactoring pullability

* Pulling: Handle disconnect properly if the pull joint has been removed by physics shutdown

* Port 2b68449328 to this branch

* Changes as per PR reviews

* Port e801ffac45 (SharedJointSystem) and fix issues encountered during testing

SharedJointSystem.

Also, MinLength and Stiffness appear to have suddenly gained enough meaning that pulling is broken unless they're set.

Content.Shared/Pulling/Systems/SharedPullerSystem.cs

@@ -1,15 +1,19 @@
 using Content.Shared.Alert;
 using Content.Shared.Hands;
+using Content.Shared.Movement.Components;
 using Content.Shared.Physics.Pull;
 using Content.Shared.Pulling.Components;
 using JetBrains.Annotations;
 using Robust.Shared.GameObjects;
+using Robust.Shared.IoC;
 
 namespace Content.Shared.Pulling.Systems
 {
     [UsedImplicitly]
     public sealed class SharedPullerSystem : EntitySystem
     {
+        [Dependency] private readonly SharedPullingSystem _pullSystem = default!;
+
         public override void Initialize()
         {
             base.Initialize();
@@ -28,7 +32,7 @@ namespace Content.Shared.Pulling.Systems
             {
                 if (EntityManager.TryGetComponent<SharedPullableComponent>(args.BlockingEntity, out var comp))
                 {
-                    comp.TryStopPull(EntityManager.GetEntity(uid));
+                    _pullSystem.TryStopPull(comp, EntityManager.GetEntity(uid));
                 }
             }
         }
@@ -43,6 +47,8 @@ namespace Content.Shared.Pulling.Systems
 
             if (component.Owner.TryGetComponent(out SharedAlertsComponent? alerts))
                 alerts.ShowAlert(AlertType.Pulling);
+
+            RefreshMovementSpeed(component);
         }
 
         private static void PullerHandlePullStopped(
@@ -55,6 +61,17 @@ namespace Content.Shared.Pulling.Systems
 
             if (component.Owner.TryGetComponent(out SharedAlertsComponent? alerts))
                 alerts.ClearAlert(AlertType.Pulling);
+
+            RefreshMovementSpeed(component);
+        }
+
+        private static void RefreshMovementSpeed(SharedPullerComponent component)
+        {
+            // Before changing how this is updated, please see SharedPullerComponent
+            if (component.Owner.TryGetComponent<MovementSpeedModifierComponent>(out var speed))
+            {
+                speed.RefreshMovementSpeedModifiers();
+            }
         }
     }
 }