Piping angle fixes (#3442)

* Moves piping prototypes to own folder

* Fixes pipe direction angles

Content.Shared/GameObjects/Components/Atmos/SharedPipeComponent.cs

@@ -77,10 +77,10 @@ namespace Content.Shared.GameObjects.Components.Atmos
         {
             return shape switch
             {
-                PipeShape.Half => PipeDirection.East,
-                PipeShape.Straight => PipeDirection.Lateral,
-                PipeShape.Bend => PipeDirection.SEBend,
-                PipeShape.TJunction => PipeDirection.TEast,
+                PipeShape.Half => PipeDirection.South,
+                PipeShape.Straight => PipeDirection.Longitudinal,
+                PipeShape.Bend => PipeDirection.SWBend,
+                PipeShape.TJunction => PipeDirection.TSouth,
                 PipeShape.Fourway => PipeDirection.Fourway,
                 _ => throw new ArgumentOutOfRangeException(nameof(shape), $"{shape} does not have an associated {nameof(PipeDirection)}."),
             };
@@ -98,14 +98,7 @@ namespace Content.Shared.GameObjects.Components.Atmos
 
         public static Angle ToAngle(this PipeDirection pipeDirection)
         {
-            return pipeDirection switch
-            {
-                PipeDirection.East  => Angle.FromDegrees(0),
-                PipeDirection.North => Angle.FromDegrees(90),
-                PipeDirection.West  => Angle.FromDegrees(180),
-                PipeDirection.South => Angle.FromDegrees(270),
-                _ => throw new ArgumentOutOfRangeException(nameof(pipeDirection), $"{pipeDirection} does not have an associated angle."),
-            };
+            return pipeDirection.ToDirection().ToAngle();
         }
 
         public static PipeDirection ToPipeDirection(this Direction direction)

Resources/Prototypes/Entities/Constructible/Piping/gascanisterports.yml

@@ -40,4 +40,4 @@
     nodes:
     - !type:PipeNode
       nodeGroupID: Pipe
-      pipeDirection: East
+      pipeDirection: South

Resources/Prototypes/Entities/Constructible/Piping/gasfilters.yml

@@ -39,16 +39,16 @@
   components:
   - type: NodeContainer
     nodes:
+    - !type:PipeNode
+      nodeGroupID: Pipe
+      pipeDirection: West
     - !type:PipeNode
       nodeGroupID: Pipe
       pipeDirection: South
     - !type:PipeNode
       nodeGroupID: Pipe
       pipeDirection: East
-    - !type:PipeNode
-      nodeGroupID: Pipe
-      pipeDirection: North
   - type: GasFilter
-    inletDirection: South
-    filterOutletDirection: East
-    outletDirection: North
+    inletDirection: West
+    filterOutletDirection: South
+    outletDirection: East

Resources/Prototypes/Entities/Constructible/Piping/pipes.yml

@@ -40,7 +40,7 @@
     nodes:
     - !type:PipeNode
       nodeGroupID: Pipe
-      pipeDirection: East
+      pipeDirection: South
   - type: Icon
     state: pipeHalf
 
@@ -53,7 +53,7 @@
     nodes:
     - !type:PipeNode
       nodeGroupID: Pipe
-      pipeDirection: Lateral
+      pipeDirection: Longitudinal
   - type: Icon
     state: pipeStraight
     
@@ -66,7 +66,7 @@
     nodes:
     - !type:PipeNode
       nodeGroupID: Pipe
-      pipeDirection: SEBend
+      pipeDirection: SWBend
   - type: Icon
     state: pipeBend
     
@@ -79,7 +79,7 @@
     nodes:
     - !type:PipeNode
       nodeGroupID: Pipe
-      pipeDirection: TEast
+      pipeDirection: TSouth
   - type: Icon
     state: pipeTJunction
     

Resources/Prototypes/Entities/Constructible/Piping/pumps.yml

@@ -40,10 +40,10 @@
     nodes:
     - !type:PipeNode
       nodeGroupID: Pipe
-      pipeDirection: West
+      pipeDirection: North
     - !type:PipeNode
       nodeGroupID: Pipe
-      pipeDirection: East
+      pipeDirection: South
   - type: PressurePump
-    inletDirection: West
-    outletDirection: East
+    inletDirection: North
+    outletDirection: South

Resources/Prototypes/Entities/Constructible/Piping/scrubbers.yml

@@ -41,6 +41,6 @@
     nodes:
     - !type:PipeNode
       nodeGroupID: Pipe
-      pipeDirection: East
+      pipeDirection: South
   - type: PressureSiphon
-    scrubberOutletDirection: East
+    scrubberOutletDirection: South

Resources/Prototypes/Entities/Constructible/Piping/vents.yml

@@ -41,6 +41,6 @@
     nodes:
     - !type:PipeNode
       nodeGroupID: Pipe
-      pipeDirection: East
+      pipeDirection: South
   - type: PressureVent
-    ventInletDirection: East
+    ventInletDirection: South