Remove prototype ignore lists from some tests (#19366)

Content.Client/Stealth/StealthSystem.cs

@@ -63,7 +63,8 @@ public sealed class StealthSystem : SharedStealthSystem
 
     private void OnShutdown(EntityUid uid, StealthComponent component, ComponentShutdown args)
     {
-        SetShader(uid, false, component);
+        if (!Terminating(uid))
+            SetShader(uid, false, component);
     }
 
     private void OnShaderRender(EntityUid uid, StealthComponent component, BeforePostShaderRenderEvent args)

Content.IntegrationTests/Tests/EntityTest.cs

@@ -153,17 +153,10 @@ namespace Content.IntegrationTests.Tests
                 .Select(p => p.ID)
                 .ToList();
 
-            // for whatever reason, stealth boxes are breaking this test. Surplus crates have a chance of spawning them.
-            // TODO fix whatever is going wrong here.
-            HashSet<string> ignored = new() { "GhostBox", "StealthBox", "CrateSyndicateSurplusBundle", "CrateSyndicateSuperSurplusBundle" };
-
             await server.WaitPost(() =>
             {
                 foreach (var protoId in protoIds)
                 {
-                    if (ignored.Contains(protoId))
-                        continue;
-
                     var mapId = mapManager.CreateMap();
                     var grid = mapManager.CreateGrid(mapId);
                     var ent = sEntMan.SpawnEntity(protoId, new EntityCoordinates(grid.Owner, 0.5f, 0.5f));

Content.IntegrationTests/Tests/Minds/MindTests.EntityDeletion.cs

@@ -71,7 +71,7 @@ public sealed partial class MindTests
     [Test]
     public async Task TestGhostOnDeleteMap()
     {
-        await using var pairTracker = await SetupPair();
+        await using var pairTracker = await SetupPair(dirty: true);
         var server = pairTracker.Pair.Server;
         var testMap = await PoolManager.CreateTestMap(pairTracker);
         var coordinates = testMap.GridCoords;

Content.IntegrationTests/Tests/PrototypeSaveTest.cs

@@ -29,18 +29,9 @@ namespace Content.IntegrationTests.Tests;
 [TestFixture]
 public sealed class PrototypeSaveTest
 {
-    private readonly HashSet<string> _ignoredPrototypes = new()
-    {
-        "Singularity", // physics collision uses "AllMask" (-1). The flag serializer currently fails to save this because this features un-named bits.
-        "constructionghost",
-        // Don't add to this list unless you have a good reason
-        // Or it is just temporary because tests stopped working and now master has too many broken entities.
-    };
-
     [Test]
     public async Task UninitializedSaveTest()
     {
-        // Apparently SpawnTest fails to clean up properly. Due to the similarities, I'll assume this also fails.
         await using var pairTracker = await PoolManager.GetServerClient();
         var server = pairTracker.Pair.Server;
 
@@ -92,9 +83,6 @@ public sealed class PrototypeSaveTest
             if (!prototype.MapSavable)
                 continue;
 
-            if (_ignoredPrototypes.Contains(prototype.ID))
-                continue;
-
             if (prototype.SetSuffix == "DEBUG")
                 continue;
 
@@ -165,10 +153,7 @@ public sealed class PrototypeSaveTest
                             var diff = compMapping.Except(protoMapping);
 
                             if (diff != null && diff.Children.Count != 0)
-                            {
+                                Assert.Fail($"Prototype {prototype.ID} modifies component on spawn: {compName}. Modified yaml:\n{diff}");
-                                var modComps = string.Join(",", diff.Keys.Select(x => x.ToString()));
-                                Assert.Fail($"Prototype {prototype.ID} modifies component on spawn: {compName}. Modified fields: {modComps}");
-                            }
                         }
                         else
                         {

Resources/Prototypes/Entities/Structures/Power/Generation/Singularity/singularity.yml

@@ -17,6 +17,8 @@
     colliderFixtureId: EventHorizonCollider
     consumerFixtureId: EventHorizonConsumer
   - type: GravityWell # To make the singularity attract things.
+    baseRadialAcceleration: 10
+    maxRange: 4
   - type: Fixtures
     fixtures:
       EventHorizonCollider:
@@ -43,11 +45,16 @@
     energy: 180
     level: 1
     radsPerLevel: 2
+    energyLoss: 1
   - type: RandomWalk # To make the singularity move around.
+    maxSpeed: 2.5
+    minSpeed: 1.875
   - type: SingularityDistortion
-    intensity: 20
+    falloffPower: 2.529822
+    intensity: 3645
   - type: RadiationSource
     slope: 0.2 # its emit really far away
+    intensity: 2
   - type: PointLight
     enabled: true
     radius: 10

Resources/Prototypes/Entities/Structures/Storage/Closets/big_boxes.yml

@@ -50,7 +50,6 @@
     - type: Tag
       tags:
         - DoorBumpOpener
-    - type: InteractionOutline
     - type: Construction
       graph: BaseBigBox
       node: basebigbox
@@ -66,6 +65,7 @@
     - type: Damageable
       damageModifierSet: FlimsyMetallic #Syndicate boxes should have a bit of protection
     - type: Stealth
+      hadOutline: true
     - type: StealthOnMove
       passiveVisibilityRate: -0.37
       movementVisibilityRate: 0.20
@@ -74,6 +74,7 @@
   id: BigBox
   parent: BaseBigBox
   components:
+  - type: InteractionOutline
   - type: Destructible
     thresholds:
     - trigger: