Remove prototype ignore lists from some tests (#19366)

This commit is contained in:
Leon Friedrich
2023-08-22 16:08:12 +12:00
committed by GitHub
parent 82d39edad8
commit 1ec014cf39
6 changed files with 14 additions and 27 deletions

View File

@@ -29,18 +29,9 @@ namespace Content.IntegrationTests.Tests;
[TestFixture]
public sealed class PrototypeSaveTest
{
private readonly HashSet<string> _ignoredPrototypes = new()
{
"Singularity", // physics collision uses "AllMask" (-1). The flag serializer currently fails to save this because this features un-named bits.
"constructionghost",
// Don't add to this list unless you have a good reason
// Or it is just temporary because tests stopped working and now master has too many broken entities.
};
[Test]
public async Task UninitializedSaveTest()
{
// Apparently SpawnTest fails to clean up properly. Due to the similarities, I'll assume this also fails.
await using var pairTracker = await PoolManager.GetServerClient();
var server = pairTracker.Pair.Server;
@@ -92,9 +83,6 @@ public sealed class PrototypeSaveTest
if (!prototype.MapSavable)
continue;
if (_ignoredPrototypes.Contains(prototype.ID))
continue;
if (prototype.SetSuffix == "DEBUG")
continue;
@@ -165,10 +153,7 @@ public sealed class PrototypeSaveTest
var diff = compMapping.Except(protoMapping);
if (diff != null && diff.Children.Count != 0)
{
var modComps = string.Join(",", diff.Keys.Select(x => x.ToString()));
Assert.Fail($"Prototype {prototype.ID} modifies component on spawn: {compName}. Modified fields: {modComps}");
}
Assert.Fail($"Prototype {prototype.ID} modifies component on spawn: {compName}. Modified yaml:\n{diff}");
}
else
{