Fix objects tab not showing nents (#23837)

* Fix objects tab not showing nents

* Fix everything

Content.Client/Administration/UI/Tabs/ObjectsTab/ObjectsTab.xaml.cs

@@ -3,6 +3,7 @@ using Robust.Client.AutoGenerated;
 using Robust.Client.UserInterface;
 using Robust.Client.UserInterface.XAML;
 using Robust.Shared.Map.Components;
+using Robust.Shared.Timing;
 
 namespace Content.Client.Administration.UI.Tabs.ObjectsTab;
 
@@ -10,12 +11,20 @@ namespace Content.Client.Administration.UI.Tabs.ObjectsTab;
 public sealed partial class ObjectsTab : Control
 {
     [Dependency] private readonly EntityManager _entityManager = default!;
+    [Dependency] private readonly IGameTiming _timing = default!;
 
     private readonly List<ObjectsTabEntry> _objects = new();
     private List<ObjectsTabSelection> _selections = new();
 
     public event Action<ObjectsTabEntry, GUIBoundKeyEventArgs>? OnEntryKeyBindDown;
 
+    // Listen I could either have like 4 different event subscribers (for map / grid / station changes) and manage their lifetimes in AdminUIController
+    // OR
+    // I can do this.
+    private TimeSpan _updateFrequency = TimeSpan.FromSeconds(2);
+
+    private TimeSpan _nextUpdate = TimeSpan.FromSeconds(2);
+
     public ObjectsTab()
     {
         RobustXamlLoader.Load(this);
@@ -33,12 +42,17 @@ public sealed partial class ObjectsTab : Control
             ObjectTypeOptions.AddItem(Enum.GetName((ObjectsTabSelection)type)!);
         }
 
+        RefreshObjectList();
+    }
+
+    private void RefreshObjectList()
+    {
         RefreshObjectList(_selections[ObjectTypeOptions.SelectedId]);
     }
 
     private void RefreshObjectList(ObjectsTabSelection selection)
     {
-        var entities = new List<EntityUid>();
+        var entities = new List<(string Name, NetEntity Entity)>();
         switch (selection)
         {
             case ObjectsTabSelection.Stations:
@@ -46,20 +60,20 @@ public sealed partial class ObjectsTab : Control
                 break;
             case ObjectsTabSelection.Grids:
             {
-                var query = _entityManager.AllEntityQueryEnumerator<MapGridComponent>();
-                while (query.MoveNext(out var uid, out _))
+                var query = _entityManager.AllEntityQueryEnumerator<MapGridComponent, MetaDataComponent>();
+                while (query.MoveNext(out var uid, out _, out var metadata))
                 {
-                    entities.Add(uid);
+                    entities.Add((metadata.EntityName, _entityManager.GetNetEntity(uid)));
                 }
 
                 break;
             }
             case ObjectsTabSelection.Maps:
             {
-                var query = _entityManager.AllEntityQueryEnumerator<MapComponent>();
-                while (query.MoveNext(out var uid, out _))
+                var query = _entityManager.AllEntityQueryEnumerator<MapComponent, MetaDataComponent>();
+                while (query.MoveNext(out var uid, out _, out var metadata))
                 {
-                    entities.Add(uid);
+                    entities.Add((metadata.EntityName, _entityManager.GetNetEntity(uid)));
                 }
                 break;
             }
@@ -74,17 +88,28 @@ public sealed partial class ObjectsTab : Control
 
         _objects.Clear();
 
-        foreach (var entity in entities)
+        foreach (var (name, nent) in entities)
         {
-            // TODO the server eitehr needs to send the entity's name, or it needs to ensure the client knows about the entity.
-            var name = _entityManager.GetComponentOrNull<MetaDataComponent>(entity)?.EntityName ?? "Unknown Entity"; // this should be fixed, so I CBF localizing.
-            var ctrl = new ObjectsTabEntry(name, entity);
+            var ctrl = new ObjectsTabEntry(name, nent);
             _objects.Add(ctrl);
             ObjectList.AddChild(ctrl);
             ctrl.OnKeyBindDown += args => OnEntryKeyBindDown?.Invoke(ctrl, args);
         }
     }
 
+    protected override void FrameUpdate(FrameEventArgs args)
+    {
+        base.FrameUpdate(args);
+
+        if (_timing.CurTime < _nextUpdate)
+            return;
+
+        // I do not care for precision.
+        _nextUpdate = _timing.CurTime + _updateFrequency;
+
+        RefreshObjectList();
+    }
+
     private enum ObjectsTabSelection
     {
         Grids,

Content.Client/Administration/UI/Tabs/ObjectsTab/ObjectsTabEntry.xaml.cs

@@ -7,13 +7,13 @@ namespace Content.Client.Administration.UI.Tabs.ObjectsTab;
 [GenerateTypedNameReferences]
 public sealed partial class ObjectsTabEntry : ContainerButton
 {
-    public EntityUid AssocEntity;
+    public NetEntity AssocEntity;
 
-    public ObjectsTabEntry(string name, EntityUid euid)
+    public ObjectsTabEntry(string name, NetEntity nent)
     {
         RobustXamlLoader.Load(this);
-        AssocEntity = euid;
-        EIDLabel.Text = euid.ToString();
+        AssocEntity = nent;
+        EIDLabel.Text = nent.ToString();
         NameLabel.Text = name;
     }
 }