bunch of prototype save fixes (#12421)

Content.IntegrationTests/Tests/PrototypeSaveTest.cs

@@ -38,41 +38,8 @@ public sealed class PrototypeSaveTest
         // TODO fix more prototypes
         // The rest of these prototypes (probably) shouldn't be getting ignored.
         // There should be an issue up tracking all of these prototypes, indicating that still need to get fixed.
-        "Thruster",
-        "Gyroscope",
-        "JawsOfLife",
-        "SyndicateJawsOfLife",
-        "PowerDrill",
-        "Omnitool",
-        "GasPressurePump",
-        "GasVolumePump",
-        "PortableScrubber",
-        "ParticleAcceleratorControlBox",
-        "GasFilter",
-        "GasFilterFlipped",
-        "GasMixer",
-        "GasMixerFlipped",
-        "HospitalCurtainsOpen",
-        "CargoPallet",
-        "ParticlesProjectile",
-        "FloorDrain",
-        "Floodlight",
-        "HolosignWetFloor",
         "HeadSkeleton",
-        "PoweredSmallLightEmpty",
-        "PoweredSmallLight",
-        "PoweredLightPostSmallEmpty",
-        "PoweredLightPostSmall",
-        "DeployableBarrier",
         "CrateArtifactContainer",
-        "CloningPod",
-        "GravityGenerator",
-        "GravityGeneratorMini",
-        "AirlockExternalShuttleLocked",
-        "AirlockExternalGlassShuttleLocked",
-        "AirlockExternalGlassShuttleEmergencyLocked",
-        "AirlockShuttle",
-        "AirlockGlassShuttle",
         // The followjng are all fixture-less phsyics entities that set can-collide to false on init.
         "CarpRift",
         "GasMinerOxygen",

Resources/Prototypes/Body/Parts/skeleton.yml

@@ -52,6 +52,7 @@
       baseSprintSpeed: 0
     - type: Speech
     - type: SkeletonAccent
+    - type: Actions
     - type: Vocal
       maleScream: /Audio/Voice/Skeleton/skeleton_scream.ogg
       femaleScream: /Audio/Voice/Skeleton/skeleton_scream.ogg
@@ -61,7 +62,6 @@
         proper: true
     - type: Examiner
     - type: DoAfter
-    - type: Actions
     - type: MobState
       thresholds:
         0: Alive

Resources/Prototypes/Entities/Objects/Misc/fluff_lights.yml

@@ -53,6 +53,8 @@
     energy: 2
   - type: ToggleableLightVisuals
   - type: Appearance
+  - type: Physics
+    canCollide: false
 
 - type: entity
   name: lamp

Resources/Prototypes/Entities/Objects/Specific/Cargo/cargo_pallet.yml

@@ -11,3 +11,5 @@
     layers:
     - texture: Structures/catwalk.rsi/catwalk_preview.png
   - type: CollideOnAnchor
+  - type: Physics
+    canCollide: false

Resources/Prototypes/Entities/Objects/Specific/Janitorial/janitor.yml

@@ -248,6 +248,7 @@
       anchored: true
     - type: Physics
       bodyType: Static
+      canCollide: false
     - type: Drain
     - type: AmbientSound
       enabled: false

Resources/Prototypes/Entities/Objects/Specific/Security/barrier.yml

@@ -12,6 +12,8 @@
     state: idle
   - type: InteractionOutline
   - type: Physics
+    bodyType: Dynamic
+    canCollide: false
   - type: Fixtures
     fixtures:
     - shape:

Resources/Prototypes/Entities/Objects/Tools/jaws_of_life.yml

@@ -24,6 +24,7 @@
     qualities:
       - Prying
     speed: 1.5
+    useSound: /Audio/Items/jaws_pry.ogg
   - type: ToolForcePowered
   - type: MultipleTool
     statusShowBehavior: true

Resources/Prototypes/Entities/Objects/Tools/tools.yml

@@ -222,6 +222,7 @@
     qualities:
       - Screwing
     speed: 1.5
+    useSound: /Audio/Items/drill_use.ogg
   - type: MultipleTool
     statusShowBehavior: true
     entries:
@@ -320,6 +321,7 @@
     qualities:
       - Screwing
     speed: 1.2 # Kept for future adjustments. Currently 1.2x for balance
+    useSound: /Audio/Items/drill_use.ogg
   - type: MultipleTool
     statusShowBehavior: true
     entries:

Resources/Prototypes/Entities/Structures/Decoration/curtains.yml

@@ -67,3 +67,5 @@
     state: Open
   - type: Occluder
     enabled: false
+  - type: Physics
+    canCollide: false

Resources/Prototypes/Entities/Structures/Holographic/projections.yml

@@ -9,6 +9,7 @@
     anchored: true
   - type: Physics
     bodyType: Static
+    canCollide: false
   - type: Sprite
     sprite: Structures/Holo/wetfloor.rsi
     state: icon

Resources/Prototypes/Entities/Structures/Lighting/base_lighting.yml

@@ -248,6 +248,9 @@
   - type: PointLight
     enabled: false
     offset: "0, -0.5"
+  - type: ContainerContainer
+    containers:
+      light_bulb: !type:ContainerSlot
   - type: PoweredLight
     bulb: Bulb
     damage:
@@ -262,6 +265,11 @@
   - type: Appearance
     visuals:
     - type: PoweredLightVisualizer
+  - type: SignalReceiver
+    inputs:
+      On: []
+      Off: []
+      Toggle: []
 
 - type: entity
   id: PoweredSmallLight

Resources/Prototypes/Entities/Structures/Lighting/ground_lighting.yml

@@ -95,6 +95,11 @@
     - type: PoweredLightVisualizer
       blinkingSound:
         path: "/Audio/Machines/light_tube_on.ogg"
+  - type: SignalReceiver
+    inputs:
+      On: []
+      Off: []
+      Toggle: []
 
 - type: entity
   id: PoweredLightPostSmall

Resources/Prototypes/Entities/Structures/Machines/cloning_machine.yml

@@ -29,6 +29,13 @@
   - type: Construction
     graph: Machine
     node: machine
+    containers:
+     - machine_board
+     - machine_parts
+     - clonepod-bodyContainer
+  - type: SignalReceiver
+    inputs:
+      CloningPodReceiver: []
   - type: EmptyOnMachineDeconstruct
     containers:
       - clonepod-bodyContainer

Resources/Prototypes/Entities/Structures/Machines/gravity_generator.yml

@@ -7,6 +7,7 @@
     mode: AlignTileAny
   components:
   - type: AmbientSound
+    enabled: false
     volume: -6
     range: 7
     sound:
@@ -25,6 +26,7 @@
   - type: Transform
     anchored: true
   - type: ApcPowerReceiver
+    powerLoad: 2500
   - type: ExtensionCableReceiver
   - type: Physics
     bodyType: Static
@@ -67,6 +69,7 @@
         off: "off"
         on: "on"
   - type: PointLight
+    radius: 2.5
     energy: 0.5
     # Gravity generator is a large machine, not casting shadows is fine within the radius set above.
     castShadows: false
@@ -103,6 +106,8 @@
       - LargeMobMask
       layer:
       - WallLayer
+  - type: ApcPowerReceiver
+    powerLoad: 500
   - type: GravityGenerator
     idlePower: 15
     activePower: 500

Resources/Prototypes/Entities/Structures/Piping/Atmospherics/binary.yml

@@ -46,6 +46,7 @@
           False: { state: pumpPressure }
   - type: PipeColorVisuals
   - type: GasPressurePump
+    enabled: false
   - type: UserInterface
     interfaces:
       - key: enum.GasPressurePumpUiKey.Key
@@ -86,6 +87,7 @@
             False: { state: pumpVolume }
     - type: PipeColorVisuals
     - type: GasVolumePump
+      enabled: false
     - type: UserInterface
       interfaces:
         - key: enum.GasVolumePumpUiKey.Key

Resources/Prototypes/Entities/Structures/Piping/Atmospherics/portable.yml

@@ -9,6 +9,7 @@
   - type: InteractionOutline
   - type: Physics
     bodyType: Dynamic
+    canCollide: false
   - type: Fixtures
     fixtures:
     - shape:

Resources/Prototypes/Entities/Structures/Piping/Atmospherics/trinary.yml

@@ -56,6 +56,7 @@
         - key: enum.GasFilterUiKey.Key
           type: GasFilterBoundUserInterface
     - type: GasFilter
+      enabled: false
     - type: Flippable
       mirrorEntity: GasFilterFlipped
     - type: Construction
@@ -142,6 +143,7 @@
         - key: enum.GasMixerUiKey.Key
           type: GasMixerBoundUserInterface
     - type: GasMixer
+      enabled: false
       inletOne: inlet
       inletTwo: filter
     - type: Flippable

Resources/Prototypes/Entities/Structures/Power/Generation/PA/control_box.yml

@@ -18,6 +18,7 @@
         - type: ParticleAcceleratorPartVisualizer
           baseState: unlit
     - type: ApcPowerReceiver
+      powerLoad: 250
     - type: ExtensionCableReceiver
     - type: ParticleAcceleratorControlBox
     - type: Construction

Resources/Prototypes/Entities/Structures/Shuttles/thrusters.yml

@@ -4,6 +4,7 @@
   abstract: true
   components:
     - type: AmbientSound
+      enabled: false
       range: 4
       volume: -4
       sound: